[jira] [Commented] (CMIS-722) getContentChanges doesn't renew HolderchangeLogToken in AtomPub Client

["Till Lorentzen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CMIS-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788074#comment-13788074 ] 

Till Lorentzen commented on CMIS-722:
-------------------------------------

I saw your changes on the getContentChanges AtomPub binding and I would like to know, if this new chemistry xml element inside the atom feed element will stay there, or is it just an attempt to add the latest change log token? I am asking, because I am using the DotCMIS lib with some tiny changes to extract the change log token from the next link. And at the moment, it is not possible to extract it from the link, because the next link has been removed and the new change log token element has been added. I could enhance the DotCMIS lib to handle the new xml element, but I would only do this, if the new element is a "stable" solution.

> getContentChanges doesn't renew Holder<String>changeLogToken in AtomPub Client
> ------------------------------------------------------------------------------
>
>                 Key: CMIS-722
>                 URL: https://issues.apache.org/jira/browse/CMIS-722
>             Project: Chemistry
>          Issue Type: Bug
>          Components: opencmis-client-bindings
>    Affects Versions: OpenCMIS 0.10.0
>            Reporter: linzhixing
>
> org.apache.chemistry.opencmis.client.bindings.spi.atompub.DiscoveryServiceImpl#getContentChanges, which is called from SessionImpl(Line:326), seems not to return a new Holder<String>changeLogToken argument. When I execute getContentChange from OpenCMIS client, changeLogToken remains the same as its input value. 
> I confirmed that my CMIS server updates Holder<String>changeLogToken to the latest token in the returned list both in debugging and Atom feed <atom:link rel="next">.
> To see org.apache.chemistry.opencmis.client.bindings.spi.webservices.DiscoveryServiceImpl#getContentChanges(Line:66), one can find
>     setHolderValue(portChangeLokToken, changeLogToken);
> but I can't find any such code in atompub DiscoveryServiceImpl.
> So I suppose some codes should be added that sets a renewed changeLogToken reading from an atom feed page link.



--
This message was sent by Atlassian JIRA
(v6.1#6144)