[jira] [Commented] (SENTRY-1945) getPathsUpdatesFrom() got its boolean logic inversed

["Alexander Kolbasov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SENTRY-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162294#comment-16162294 ] 

Alexander Kolbasov commented on SENTRY-1945:
--------------------------------------------

[~spena] FYI
Thanks [~vamsee] for finding the problem

> getPathsUpdatesFrom() got its boolean logic inversed
> ----------------------------------------------------
>
>                 Key: SENTRY-1945
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1945
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>    Affects Versions: 2.0.0
>            Reporter: Alexander Kolbasov
>            Assignee: Sergio Peña
>            Priority: Blocker
>
> Sentry-1919 introduced the following code in getPathsUpdatesFrom():
> {code}
>     if (pathsRetrieverBusy.compareAndSet(false, true)) {
>       LOGGER.debug("PATHS updates are not available because another request is in progress.");
>       return Collections.emptyList();
>     }
> {code}
> It is easy to see that the code check is inversed and we are doing quite the opposite of what we want to do.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)