You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/11/16 16:23:00 UTC
[jira] [Work logged] (HIVE-25405) Implement Connector Provider for Amazon Redshift
[ https://issues.apache.org/jira/browse/HIVE-25405?focusedWorklogId=682086&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-682086 ]
ASF GitHub Bot logged work on HIVE-25405:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Nov/21 16:22
Start Date: 16/Nov/21 16:22
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on a change in pull request #2546:
URL: https://github.com/apache/hive/pull/2546#discussion_r750441378
##########
File path: ql/src/test/queries/clientpositive/redshift_data_connector.q
##########
@@ -0,0 +1,65 @@
+-- SORT_QUERY_RESULTS
+SHOW CONNECTORS;
+
+-- CREATE with comment
+CREATE CONNECTOR redshift_test
+TYPE 'redshift'
+URL 'jdbc:redshift://redshift-cluster-1.c1gffkxfot1v.us-east-2.redshift.amazonaws.com:5439/dev'
Review comment:
this seems like an external resource - that's not something we should have in a unit test
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/PostgreSQLConnectorProvider.java
##########
@@ -12,7 +12,7 @@
import java.util.List;
public class PostgreSQLConnectorProvider extends AbstractJDBCConnectorProvider {
- private static Logger LOG = LoggerFactory.getLogger(MySQLConnectorProvider.class);
+ private static Logger LOG = LoggerFactory.getLogger(PostgreSQLConnectorProvider.class);
Review comment:
lol :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 682086)
Time Spent: 40m (was: 0.5h)
> Implement Connector Provider for Amazon Redshift
> ------------------------------------------------
>
> Key: HIVE-25405
> URL: https://issues.apache.org/jira/browse/HIVE-25405
> Project: Hive
> Issue Type: Sub-task
> Reporter: Narayanan Venkateswaran
> Assignee: Narayanan Venkateswaran
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> h2. +DB Level Federation to Redshift+
> The work in this Jira helps setup federation to redshift databases at the DB level, in the following way.
> {noformat}
> 0: jdbc:hive2://> describe connector redshift_test_7;
> 21/07/30 20:53:53 [343005b1-06f3-4891-81d1-0c6ad8612260 main]: WARN lazy.LazyStruct: Extra bytes detected at the end of the row! Ignoring similar problems.
> +------------------+-----------+----------------------------------------------------+-------------+-------------+--------------------------+
> | name | type | url | owner_name | owner_type | comment |
> +------------------+-----------+----------------------------------------------------+-------------+-------------+--------------------------+
> | redshift_test_7 | redshift | jdbc:redshift://<url> | narayanan | USER | test redshift connector |
> +------------------+-----------+----------------------------------------------------+-------------+-------------+--------------------------+
> 1 row selected (0.054 seconds) {noformat}
> {noformat}
> 0: jdbc:hive2://> describe database db_redshift_7;
> 21/07/30 20:53:38 [343005b1-06f3-4891-81d1-0c6ad8612260 main]: WARN lazy.LazyStruct: Extra bytes detected at the end of the row! Ignoring similar problems.
> +----------------+----------+-----------+------------------+-------------+-------------+------------------+----------------+
> | db_name | comment | location | managedlocation | owner_name | owner_type | connector_name | remote_dbname |
> +----------------+----------+-----------+------------------+-------------+-------------+------------------+----------------+
> | db_redshift_7 | | | | narayanan | USER | redshift_test_7 | dev |
> +----------------+----------+-----------+------------------+-------------+-------------+------------------+----------------+
> 1 row selected (0.066 seconds) {noformat}
> {noformat}
> 0: jdbc:hive2://> use db_redshift_7;
> No rows affected (1.391 seconds) {noformat}
> {noformat}
> 0: jdbc:hive2://> show tables;
> +-----------------+
> | tab_name |
> +-----------------+
> | accommodations |
> | category |
> | date |
> | event |
> | listing |
> | sales |
> | sample |
> | test_float_4 |
> | test_int_2 |
> | test_int_4 |
> | test_int_8 |
> | test_time |
> | test_time_2 |
> | test_timestamp |
> | users |
> | venue |
> | zipcode |
> +-----------------+
> 17 rows selected (7.773 seconds) {noformat}
> {noformat}
> 0: jdbc:hive2://> select * from test_float_4;
> +-----------------+
> | test_float_4.i |
> +-----------------+
> | 1.0 |
> +-----------------+
> 1 row selected (18.214 seconds) {noformat}
> {noformat}
> 0: jdbc:hive2://> select * from test_int_8;
> +---------------+
> | test_int_8.i |
> +---------------+
> | 1 |
> +---------------+
> 1 row selected (12.626 seconds) {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)