You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/03/20 08:38:43 UTC
[GitHub] [pulsar-client-go] wolfstudy opened a new pull request #202:
[Issue: 201] Expose GetDeliveryCount method from Message interface
wolfstudy opened a new pull request #202: [Issue: 201] Expose GetDeliveryCount method from Message interface
URL: https://github.com/apache/pulsar-client-go/pull/202
Signed-off-by: xiaolong.ran <rx...@apache.org>
Master Issue: #201
### Modifications
- Expose `GetDeliveryCount()` method from `Message` interface
- Add test case to verfiy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request
#202: [Issue: 201] Expose GetDeliveryCount method from Message interface
Posted by GitBox <gi...@apache.org>.
cckellogg commented on a change in pull request #202: [Issue: 201] Expose GetDeliveryCount method from Message interface
URL: https://github.com/apache/pulsar-client-go/pull/202#discussion_r395724243
##########
File path: pulsar/message.go
##########
@@ -86,6 +86,13 @@ type Message interface {
// Key get the key of the message, if any
Key() string
+
+ // Get message redelivery count, redelivery count maintain in pulsar broker. When client nack acknowledge messages,
+ // broker will dispatch message again with message redelivery count in CommandMessage defined.
+ //
+ // Message redelivery increases monotonically in a broker, when topic switch ownership to a another broker
+ // redelivery count will be recalculated.
+ GetDeliveryCount() uint32
Review comment:
`RedeliveryCount()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy merged pull request #202: [Issue: 201]
Expose GetDeliveryCount method from Message interface
Posted by GitBox <gi...@apache.org>.
wolfstudy merged pull request #202: [Issue: 201] Expose GetDeliveryCount method from Message interface
URL: https://github.com/apache/pulsar-client-go/pull/202
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services