You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/27 17:43:54 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #8512: Disable
deprecated druid connector by default
codecov-io commented on issue #8512: Disable deprecated druid connector by default
URL: https://github.com/apache/incubator-superset/pull/8512#issuecomment-559188267
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8512?src=pr&el=h1) Report
> Merging [#8512](https://codecov.io/gh/apache/incubator-superset/pull/8512?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/acf0753504095a5c0e320b049370aaf6f04e5a4f?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8512?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8512 +/- ##
=========================================
- Coverage 65.76% 65.7% -0.06%
=========================================
Files 482 482
Lines 23824 23834 +10
Branches 2594 2594
=========================================
- Hits 15667 15661 -6
- Misses 7984 8000 +16
Partials 173 173
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8512?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/8512/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.86% <100%> (ø)` | :arrow_up: |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/8512/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `64% <0%> (-5.34%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8512/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.27% <0%> (-0.91%)` | :arrow_down: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8512/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `81.83% <0%> (-0.6%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/8512/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `22.58% <0%> (-0.06%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/8512/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `78.03% <0%> (+0.1%)` | :arrow_up: |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/8512/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.13% <0%> (+1.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8512?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8512?src=pr&el=footer). Last update [acf0753...f2d0d3a](https://codecov.io/gh/apache/incubator-superset/pull/8512?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org