[GitHub] [pulsar] mattisonchao commented on a change in pull request #14163: [Management] Make ``BrokerBase#deleteDynamicConfiguration`` to pure async method.

[GitBox <gi...@apache.org>]

mattisonchao commented on a change in pull request #14163:
URL: https://github.com/apache/pulsar/pull/14163#discussion_r801634707



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/BrokersBase.java
##########
@@ -379,27 +390,16 @@ public void healthCheck(@Suspended AsyncResponse asyncResponse,
                 });
     }
 
-    private synchronized void deleteDynamicConfigurationOnZk(String configName) {
-        try {
-            if (BrokerService.isDynamicConfiguration(configName)) {
-                dynamicConfigurationResources().setDynamicConfiguration(old -> {
-                    if (old != null) {
-                        old.remove(configName);
-                    }
-                    return old;
-                });
-                LOG.info("[{}] Deleted Service configuration {}", clientAppId(), configName);
-            } else {
-                if (LOG.isDebugEnabled()) {
-                    LOG.debug("[{}] Can't update non-dynamic configuration {}", clientAppId(), configName);
+    private synchronized CompletableFuture<Void> internalDeleteDynamicConfigurationOnMetadataAsync(String configName) {

Review comment:
       ```suggestion
       private CompletableFuture<Void> internalDeleteDynamicConfigurationOnMetadataAsync(String configName) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org