You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tcl.apache.org by mx...@apache.org on 2022/02/19 10:41:15 UTC
[tcl-rivet] 03/03: rephrasing comments and fix URL in documentation
This is an automated email from the ASF dual-hosted git repository.
mxmanghi pushed a commit to branch quattuor
in repository https://gitbox.apache.org/repos/asf/tcl-rivet.git
commit da7210336c60a24e1341cba047c5bab3052b3675
Author: Massimo Manghi <mx...@apache.org>
AuthorDate: Sat Feb 19 11:40:49 2022 +0100
rephrasing comments and fix URL in documentation
---
ChangeLog | 5 +++++
doc/rivet.css | 4 ++--
doc/xml/internals.xml | 2 +-
src/mod_rivet_ng/rivetCore.c | 10 +++++-----
4 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 866aba6..b049f76 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2022-02-19 Massimo Manghi <mx...@apache.org>
+ * src/mod_rivet_ng/rivetCore.c: rephrasing comment
+ * doc/xml/internals.xml: fix URL to git repository (it still was pointing to SVN)
+ * doc/rivet.css: removing trailing spaces
+
2022-02-14 Massimo Manghi <mx...@apache.org>
* src/mod_rivet_ng/rivetCore.c: New feature of the '::rivet::var all' commands.
An extra optional argument is interpreted as a dictionary of default values
diff --git a/doc/rivet.css b/doc/rivet.css
index 71ae239..6a9e47b 100644
--- a/doc/rivet.css
+++ b/doc/rivet.css
@@ -340,7 +340,7 @@ table.namespaces {
}
.namespaces tr.init {
- background-color: #bb8766;
+ background-color: #bb8766;
}
.namespaces tr.childinit {
@@ -348,7 +348,7 @@ table.namespaces {
}
.namespaces tr.processing {
- background-color: #bb8766;
+ background-color: #bb8766;
}
.namespaces tr.childexit {
diff --git a/doc/xml/internals.xml b/doc/xml/internals.xml
index d5cd7a3..8b70b43 100644
--- a/doc/xml/internals.xml
+++ b/doc/xml/internals.xml
@@ -138,7 +138,7 @@
the <emphasis>worker</emphasis> MPM bridge the finalize function
is called after the current thread itself is set up for termination.
See function Rivet_ExitCmd in
- <ulink url="https://svn.apache.org/repos/asf/tcl/rivet/trunk/src/mod_rivet_ng/rivetCore.c">rivetCore.c</ulink>
+ <ulink url="https://gitbox.apache.org/repos/asf?p=tcl-rivet.git;a=blob;f=src/mod_rivet_ng/rivetCore.c">rivetCore.c</ulink>
to have details on how and at what stage this callback is invoked.
</listitem>
<listitem>
diff --git a/src/mod_rivet_ng/rivetCore.c b/src/mod_rivet_ng/rivetCore.c
index 251fb22..3b1295c 100644
--- a/src/mod_rivet_ng/rivetCore.c
+++ b/src/mod_rivet_ng/rivetCore.c
@@ -794,16 +794,15 @@ TCL_CMD_HEADER ( Rivet_Var )
*/
if (Tcl_DictObjFirst(interp,objv[2],&search,&key,&value,&done) != TCL_OK) {
- /* If the object passed as optional argument is a valid dictionary it
- * shouldn't never get here
- */
+ /* If the object passed as optional argument is
+ * a valid dictionary we shouldn't get here */
Tcl_SetStringObj(result,"invalid_dictionary_value",-1);
/* We use the result Tcl_Obj to assign an error code. This should also release the object memory */
Tcl_SetObjErrorCode(interp,result);
- Tcl_AddObjErrorInfo(interp,"Impossible to interpret the default values argument as a dictionary value",-1);
+ Tcl_AddObjErrorInfo(interp,"Impossible to interpret the optional defaults argument as a dictionary value",-1);
return TCL_ERROR;
}
@@ -823,13 +822,14 @@ TCL_CMD_HEADER ( Rivet_Var )
}
} else {
+
/* bad command */
Tcl_AppendResult(interp,"bad option: must be one of ",
"'get, list, names, number, all'", NULL);
return TCL_ERROR;
+
}
Tcl_SetObjResult(interp, result);
-
return TCL_OK;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@tcl.apache.org
For additional commands, e-mail: commits-help@tcl.apache.org