You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by sgururajshetty <gi...@git.apache.org> on 2018/05/18 11:25:06 UTC

[GitHub] carbondata pull request #2320: [Documentation] Editorial review comment fixe...

GitHub user sgururajshetty opened a pull request:

    https://github.com/apache/carbondata/pull/2320

    [Documentation] Editorial review comment fixed

     Editorial review comment fixed

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sgururajshetty/carbondata Editorial_Review

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2320.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2320
    
----
commit f8236ae2eb9e52d22f37a4b61967260071a50957
Author: sgururajshetty <sg...@...>
Date:   2018-05-18T11:29:38Z

    Editorial review comment fixed

----


---

[GitHub] carbondata issue #2320: [Documentation] Editorial review comment fixed

Posted by kunal642 <gi...@git.apache.org>.

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2320
  
    LGTM


---

[GitHub] carbondata pull request #2320: [Documentation] Editorial review comment fixe...

Posted by jackylk <gi...@git.apache.org>.

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2320#discussion_r189422348
  
    --- Diff: docs/data-management-on-carbondata.md ---
    @@ -39,7 +39,7 @@ This tutorial is going to introduce all commands and data operations on CarbonDa
       [TBLPROPERTIES (property_name=property_value, ...)]
       [LOCATION 'path']
       ```
    -  **NOTE:** CarbonData also supports "STORED AS carbondata". Find example code at [CarbonSessionExample](https://github.com/apache/carbondata/blob/master/examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonSessionExample.scala) in the CarbonData repo.
    +  **NOTE:** CarbonData also supports "STORED AS carbondata" and "USING carbondata". Find example code at [CarbonSessionExample](https://github.com/apache/carbondata/blob/master/examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonSessionExample.scala) in the CarbonData repo.
    --- End diff --
    
    I think we should change the example in line 38 to encourage user to use `STORED AS` as it is the standard Hive syntax


---

[GitHub] carbondata issue #2320: [Documentation] Editorial review comment fixed

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2320
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4853/



---

[GitHub] carbondata issue #2320: [Documentation] Editorial review comment fixed

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2320
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5184/



---

[GitHub] carbondata issue #2320: [Documentation] Editorial review comment fixed

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2320
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6210/



---

[GitHub] carbondata issue #2320: [Documentation] Editorial review comment fixed

Posted by kunal642 <gi...@git.apache.org>.

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/2320
  
    LGTM


---

[GitHub] carbondata issue #2320: [Documentation] Editorial review comment fixed

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2320
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4811/



---

[GitHub] carbondata issue #2320: [Documentation] Editorial review comment fixed

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2320
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6011/



---

[GitHub] carbondata issue #2320: [Documentation] Editorial review comment fixed

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2320
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5048/



---

[GitHub] carbondata pull request #2320: [Documentation] Editorial review comment fixe...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2320


---

[GitHub] carbondata issue #2320: [Documentation] Editorial review comment fixed

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2320
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4994/



---

[GitHub] carbondata issue #2320: [Documentation] Editorial review comment fixed

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2320
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5968/



---