You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "alexeyinkin (via GitHub)" <gi...@apache.org> on 2023/02/13 16:58:40 UTC
[GitHub] [beam] alexeyinkin commented on a diff in pull request #25034: Test loading URLs
alexeyinkin commented on code in PR #25034:
URL: https://github.com/apache/beam/pull/25034#discussion_r1104766650
##########
playground/frontend/playground_components_dev/lib/src/examples/example_descriptor.dart:
##########
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// ignore_for_file: prefer_interpolation_to_compose_strings
+
+import 'package:http/http.dart' as http;
+import 'package:playground_components/playground_components.dart';
+
+import '../code.dart';
+
+const _noGraphSdks = [Sdk.go, Sdk.scio];
+
+/// Describes an example for the purpose of integration tests.
+class ExampleDescriptor {
+ static const _schemaAndHost = 'https://raw.githubusercontent.com/';
+
+ static const _defaultRepositoryAndRef = 'apache/beam/master';
+ // If running before this is deployed, change to this:
+ // static const _defaultRepositoryAndRef =
+ // 'akvelon/beam/issue24959_test-loading-url';
+
+ const ExampleDescriptor(
+ this.name, {
+ required this.dbPath,
+ required this.path,
+ required this.sdk,
+ this.contextLine1Based,
+ this.croppedFoldedVisibleText,
+ this.foldedVisibleText,
+ this.outputContains,
+ this.outputTail,
+ this.repositoryAndRef = _defaultRepositoryAndRef,
+ });
+
+ /// 1-based line index to set cursor to.
+ final int? contextLine1Based;
+
+ /// A token to retrieve the example from server.
+ final String dbPath;
+
+ /// Name as shown in the dropdown.
+ final String name;
+
+ /// File path relative to the repository root, starting with `/`.
+ final String path;
+
+ final String repositoryAndRef;
Review Comment:
`+`
##########
playground/frontend/playground_components_dev/lib/src/examples/example_descriptor.dart:
##########
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// ignore_for_file: prefer_interpolation_to_compose_strings
+
+import 'package:http/http.dart' as http;
+import 'package:playground_components/playground_components.dart';
+
+import '../code.dart';
+
+const _noGraphSdks = [Sdk.go, Sdk.scio];
+
+/// Describes an example for the purpose of integration tests.
+class ExampleDescriptor {
+ static const _schemaAndHost = 'https://raw.githubusercontent.com/';
+
+ static const _defaultRepositoryAndRef = 'apache/beam/master';
+ // If running before this is deployed, change to this:
+ // static const _defaultRepositoryAndRef =
+ // 'akvelon/beam/issue24959_test-loading-url';
+
+ const ExampleDescriptor(
+ this.name, {
+ required this.dbPath,
+ required this.path,
+ required this.sdk,
+ this.contextLine1Based,
+ this.croppedFoldedVisibleText,
+ this.foldedVisibleText,
+ this.outputContains,
+ this.outputTail,
+ this.repositoryAndRef = _defaultRepositoryAndRef,
+ });
+
+ /// 1-based line index to set cursor to.
+ final int? contextLine1Based;
+
+ /// A token to retrieve the example from server.
+ final String dbPath;
+
+ /// Name as shown in the dropdown.
+ final String name;
+
+ /// File path relative to the repository root, starting with `/`.
+ final String path;
+
+ final String repositoryAndRef;
+
+ final Sdk sdk;
Review Comment:
`+`
##########
playground/frontend/playground_components_dev/lib/src/examples/example_descriptor.dart:
##########
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// ignore_for_file: prefer_interpolation_to_compose_strings
+
+import 'package:http/http.dart' as http;
+import 'package:playground_components/playground_components.dart';
+
+import '../code.dart';
+
+const _noGraphSdks = [Sdk.go, Sdk.scio];
+
+/// Describes an example for the purpose of integration tests.
+class ExampleDescriptor {
+ static const _schemaAndHost = 'https://raw.githubusercontent.com/';
+
+ static const _defaultRepositoryAndRef = 'apache/beam/master';
+ // If running before this is deployed, change to this:
+ // static const _defaultRepositoryAndRef =
+ // 'akvelon/beam/issue24959_test-loading-url';
+
+ const ExampleDescriptor(
+ this.name, {
+ required this.dbPath,
+ required this.path,
+ required this.sdk,
+ this.contextLine1Based,
+ this.croppedFoldedVisibleText,
+ this.foldedVisibleText,
+ this.outputContains,
+ this.outputTail,
+ this.repositoryAndRef = _defaultRepositoryAndRef,
+ });
+
+ /// 1-based line index to set cursor to.
+ final int? contextLine1Based;
+
+ /// A token to retrieve the example from server.
+ final String dbPath;
+
+ /// Name as shown in the dropdown.
+ final String name;
+
+ /// File path relative to the repository root, starting with `/`.
+ final String path;
+
+ final String repositoryAndRef;
+
+ final Sdk sdk;
+
+ /// Visible text when using `visibleSectionNames` and `foldOutsideSections()`.
+ final String? croppedFoldedVisibleText;
+
+ /// Visible text when using `foldOutsideSections()`.
+ final String? foldedVisibleText;
+
+ final List<String>? outputContains;
Review Comment:
`+`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org