You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2010/01/26 01:35:07 UTC
[Bug 6305] New: RATWARE_GECKO_BUILD has y2010 bug
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6305
Summary: RATWARE_GECKO_BUILD has y2010 bug
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: Other
OS/Version: All
Status: NEW
Severity: enhancement
Priority: P5
Component: Rules
AssignedTo: dev@spamassassin.apache.org
ReportedBy: jgmyers@proofpoint.com
Created an attachment (id=4658)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4658)
Patch to defer bug for a decade
RATWARE_GECKO_BUILD incorrectly fires on messages composed by the latest
release of Thunderbird.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6305] [review] RATWARE_GECKO_BUILD has y2010 bug
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6305
abillington@tetragonpublishing.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |abillington@tetragonpublish
| |ing.com
--- Comment #4 from abillington@tetragonpublishing.com 2010-01-28 09:15:17 UTC ---
Mine does seem to trigger it (running from XP anyway, possibly also from Mac):
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.1.7)
Gecko/20100111 Lightning/1.0b1 Thunderbird/3.0.1
X-Spam-Report: 1.7 RATWARE_GECKO_BUILD Bulk email fingerprint (Gecko faked)
found
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6305] [review] RATWARE_GECKO_BUILD has y2010 bug
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6305
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P4
Target Milestone|Undefined |3.3.1
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6305] [review] RATWARE_GECKO_BUILD has y2010 bug
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6305
John Gardiner Myers <jg...@proofpoint.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 |P3
CC| |jgmyers@proofpoint.com
Summary|RATWARE_GECKO_BUILD has |[review]
|y2010 bug |RATWARE_GECKO_BUILD has
| |y2010 bug
Severity|enhancement |normal
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6305] [review] RATWARE_GECKO_BUILD has y2010 bug
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6305
--- Comment #6 from Alex <ab...@tetragonpublishing.com> 2010-01-29 08:32:36 UTC ---
Same for Mac, running OS X 10.5:
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-GB; rv:1.9.1.7)
Gecko/20100111 Lightning/1.0b1 Thunderbird/3.0.1
X-Spam-Report: 1.7 RATWARE_GECKO_BUILD Bulk email fingerprint (Gecko faked)
found
Alex
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6305] [review] RATWARE_GECKO_BUILD has y2010 bug
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6305
--- Comment #11 from Kevin A. McGrail <km...@pccc.com> 2010-01-31 06:22:08 UTC ---
(In reply to comment #10)
> After all sorts of debugging I finally tracked down the reason while the rule
> did not fire with the pattern /Gecko\/(?!200\d\d\d\d\d)\d/ on my machine.
>
> First of all, my local.cf test rule TEST_GB1 was removed by duplicate rule
> detection
>
> [35591] dbg: rules: RATWARE_GECKO_BUILD merged duplicates: TEST_GB1
>
> So I was still only looking at RATWARE_GECKO_BUILD
>
> Second, notice this line in 3.003000/updates_spamassassin_org/50_scores.cf
>
> score RATWARE_GECKO_BUILD 0 # n=0 n=1 n=2 n=3
>
> That seems to explain it :) When I set the score to 1 in local.cf the rule
> fires fine. I think we can put that problem to bed.
>
> +1 on the proposed fix
The proposed patch doesn't fix the score issue. Are you proposing a patch to a
score of 1 AND the attached gecko.diff? If so, I'm +1.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6305] [review] RATWARE_GECKO_BUILD has y2010 bug
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6305
--- Comment #13 from Justin Mason <jm...@jmason.org> 2010-02-01 02:57:57 UTC ---
(In reply to comment #12)
> (in reply to comment #11)
>
> I just assumed that somebody pushed a score 0 out to updates while we dealt
> with the false positives that this y2k10 bug was generating. If that didn't
> happen, why is the rule there with a score of 0? What score is it supposed to
> be set at?
fwiw, it's zeroed in trunk:
: 41...; ./spamassassin -Lt < tst | grep -C2 X-Spam-Status
jmason.ubuntu.amazon.com
X-Spam-Level:
X-Spam-Status: No, score=0.0 required=5.0 tests=T_FSL_HELO_NON_FQDN_2,
T_KHOP_NEWSLETTER,T_KHOP_PGP_INLINE,T_RP_MATCHES_RCVD
autolearn=unavailable
version=3.4.0-r904526
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6305] RATWARE_GECKO_BUILD has y2010 bug
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6305
John Gardiner Myers <jg...@proofpoint.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #16 from John Gardiner Myers <jg...@proofpoint.com> 2010-02-03 14:08:02 UTC ---
Actually, the score issue is an entirely separate bug. Resolving this bug.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6305] [review] RATWARE_GECKO_BUILD has y2010 bug
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6305
--- Comment #2 from Warren Togami <wt...@redhat.com> 2010-01-25 19:14:18 UTC ---
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7)
Gecko/20100120 Fedora/3.0.1-1.fc12 Thunderbird/3.0.1
My Thunderbird doesn't appear to be triggering this rule.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6305] [review] RATWARE_GECKO_BUILD has y2010 bug
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6305
Sidney Markowitz <si...@sidney.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sidney@sidney.com
--- Comment #9 from Sidney Markowitz <si...@sidney.com> 2010-01-30 05:26:36 UTC ---
I suspect that it is not differences in their t-bird user-agent causing some
people to not see the rule triggered, but differences in the perl they are
running. I'm seeing the rule not being triggered to and I did the following
experiment.
I created a test message with the following line both in the headers and again
in the body:
User-Agent: Gecko/20100111 Lightning
I then added the following to local.cf:
header TEST_GB1 User-Agent =~ /Gecko\/(?!200\d\d\d\d\d)\d/
describe TEST_GB1 Test header 1
score TEST_GB1 1.0
header TEST_GB2 User-Agent =~ /Gecko\/(?!200\d\d\d\d\d)[0-9]/
describe TEST_GB2 Test header 2
score TEST_GB2 1.0
header TEST_GB3 User-Agent =~ /Gecko\/(?!200\d\d\d\d\d)(\d)/
describe TEST_GB3 Test header 3
score TEST_GB3 1.0
rawbody TEST_GB4 /User-Agent: Gecko\/(?!200\d\d\d\d\d)\d/
describe TEST_GB4 Test rawbody
score TEST_GB4 1.0
body TEST_GB5 /User-Agent: Gecko\/(?!200\d\d\d\d\d)\d/
describe TEST_GB5 Test body
score TEST_GB5 1.0
I then ran spamassassin -t -L on the message and the result was that TEST_GB1
did not hit and all the others did.
I can't explain the results, but notice that the problem only occurs in a
header rule and that it goes away if you change the final \d into either [0-9]
or into (\d)
Any ideas about how this can be true? BTW, I'm running perl 5.8.9 from MacPorts
under Mac OS 10.6.2
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6305] [review] RATWARE_GECKO_BUILD has y2010 bug
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6305
--- Comment #7 from Adam Katz <an...@khopis.com> 2010-01-29 11:52:09 UTC ---
This bug is twofold:
1. The important part: Fix the regex!
This is easy and has a patch.
+1 do it now.
2. The tougher part: figure out why this doesn't fire all the time.
Since it IS firing some of the time, let's knock out #1 ASAP and then deal with
#2.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6305] RATWARE_GECKO_BUILD has y2010 bug
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6305
John Gardiner Myers <jg...@proofpoint.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #4658|0 |1
is obsolete| |
--- Comment #1 from John Gardiner Myers <jg...@proofpoint.com> 2010-01-25 17:09:50 UTC ---
Created an attachment (id=4659)
--> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4659)
Patch to defer bug for three decades
On second thought, push this back until sometime after I retire.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6305] RATWARE_GECKO_BUILD has y2010 bug
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6305
John Gardiner Myers <jg...@proofpoint.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Summary|[review] |RATWARE_GECKO_BUILD has
|RATWARE_GECKO_BUILD has |y2010 bug
|y2010 bug |
--- Comment #15 from John Gardiner Myers <jg...@proofpoint.com> 2010-02-03 14:05:12 UTC ---
Committed revision 906263.
Leaving bug open in case someone else wants to deal with the score issue.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6305] [review] RATWARE_GECKO_BUILD has y2010 bug
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6305
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kmcgrail@pccc.com
--- Comment #8 from Kevin A. McGrail <km...@pccc.com> 2010-01-29 15:43:12 UTC ---
(In reply to comment #7)
> This bug is twofold:
>
> 1. The important part: Fix the regex!
> This is easy and has a patch.
> +1 do it now.
>
> 2. The tougher part: figure out why this doesn't fire all the time.
>
> Since it IS firing some of the time, let's knock out #1 ASAP and then deal with
> #2.
I'm +1 on the very small fix and keeping the ticket open.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6305] [review] RATWARE_GECKO_BUILD has y2010 bug
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6305
--- Comment #12 from Sidney Markowitz <si...@sidney.com> 2010-01-31 10:45:50 UTC ---
(in reply to comment #11)
I just assumed that somebody pushed a score 0 out to updates while we dealt
with the false positives that this y2k10 bug was generating. If that didn't
happen, why is the rule there with a score of 0? What score is it supposed to
be set at?
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6305] RATWARE_GECKO_BUILD has y2010 bug
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6305
Adam Katz <an...@khopis.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |6323
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6305] [review] RATWARE_GECKO_BUILD has y2010 bug
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6305
--- Comment #10 from Sidney Markowitz <si...@sidney.com> 2010-01-30 15:25:20 UTC ---
After all sorts of debugging I finally tracked down the reason while the rule
did not fire with the pattern /Gecko\/(?!200\d\d\d\d\d)\d/ on my machine.
First of all, my local.cf test rule TEST_GB1 was removed by duplicate rule
detection
[35591] dbg: rules: RATWARE_GECKO_BUILD merged duplicates: TEST_GB1
So I was still only looking at RATWARE_GECKO_BUILD
Second, notice this line in 3.003000/updates_spamassassin_org/50_scores.cf
score RATWARE_GECKO_BUILD 0 # n=0 n=1 n=2 n=3
That seems to explain it :) When I set the score to 1 in local.cf the rule
fires fine. I think we can put that problem to bed.
+1 on the proposed fix
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6305] [review] RATWARE_GECKO_BUILD has y2010 bug
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6305
--- Comment #14 from Justin Mason <jm...@jmason.org> 2010-02-01 03:03:01 UTC ---
+1 on the second rule patch
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6305] [review] RATWARE_GECKO_BUILD has y2010 bug
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6305
Justin Mason <jm...@jmason.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P4 |P2
CC| |jm@jmason.org
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6305] [review] RATWARE_GECKO_BUILD has y2010 bug
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6305
--- Comment #5 from Alex <ab...@tetragonpublishing.com> 2010-01-28 09:43:12 UTC ---
Incidentally, this is with 3.2.4. Is there any temporary fix for this issue? It
could be a bit of a problem as my whole office use Thunderbird.
(In reply to comment #4)
> Mine does seem to trigger it (running from XP anyway, possibly also from Mac):
>
> User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.1.7)
> Gecko/20100111 Lightning/1.0b1 Thunderbird/3.0.1
> X-Spam-Report: 1.7 RATWARE_GECKO_BUILD Bulk email fingerprint (Gecko faked)
> found
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6305] [review] RATWARE_GECKO_BUILD has y2010 bug
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6305
Adam Katz <an...@khopis.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |antispam@khopis.com
--- Comment #3 from Adam Katz <an...@khopis.com> 2010-01-25 20:20:45 UTC ---
(In reply to comment #2)
> User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7)
> Gecko/20100120 Fedora/3.0.1-1.fc12 Thunderbird/3.0.1
>
> My Thunderbird doesn't appear to be triggering this rule.
Agreed. I have SA 3.2.5 and Thunderbird 3.0.1 that also does not match ...
despite that a raw run of perl matches it...
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.7) Gecko/20100121
Lightning/1.0b1 Icedove/3.0.1
No mention of it in the debug output either, and I definitely have that rule.
http://ruleqa.spamassassin.org/?rule=RATWARE_GECKO_BUILD
Also doesn't hit the masscheck, either due to a bug or the fact that nobody
forges this with a future date. I suspect both.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.