You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org> on 2021/07/19 20:57:20 UTC

[Impala-ASF-CR] IMPALA-10805: [DOCS] Document priority based scratch directory selection 

Shajini Thayasingh has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17700


Change subject: IMPALA-10805: [DOCS] Document priority based scratch directory selection
......................................................................

IMPALA-10805: [DOCS] Document priority based scratch directory selection

Explained how to configure priorities for the scratch directories.
Provided an example displaying priority based configuration.

Change-Id: Iec170fdefcde09d4ee99d06b0876a17eb0bde2f6
---
M docs/topics/impala_disk_space.xml
1 file changed, 31 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/17700/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec170fdefcde09d4ee99d06b0876a17eb0bde2f6
Gerrit-Change-Number: 17700
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>

[Impala-ASF-CR] IMPALA-10805: [DOCS] Document priority based scratch directory selection

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17700 )

Change subject: IMPALA-10805: [DOCS] Document priority based scratch directory selection
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/643/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/17700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec170fdefcde09d4ee99d06b0876a17eb0bde2f6
Gerrit-Change-Number: 17700
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Jul 2021 21:04:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10805: [DOCS] Document priority based scratch directory selection

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17700 )

Change subject: IMPALA-10805: [DOCS] Document priority based scratch directory selection
......................................................................


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/644/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/17700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec170fdefcde09d4ee99d06b0876a17eb0bde2f6
Gerrit-Change-Number: 17700
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 16:03:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10805: [DOCS] Document priority based scratch directory selection

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17700 )

Change subject: IMPALA-10805: [DOCS] Document priority based scratch directory selection
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/374/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec170fdefcde09d4ee99d06b0876a17eb0bde2f6
Gerrit-Change-Number: 17700
Gerrit-PatchSet: 4
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Jul 2021 15:47:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10805: [DOCS] Document priority based scratch directory selection

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17700 )

Change subject: IMPALA-10805: [DOCS] Document priority based scratch directory selection
......................................................................


Patch Set 3:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/645/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/17700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec170fdefcde09d4ee99d06b0876a17eb0bde2f6
Gerrit-Change-Number: 17700
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 16:32:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10805: [DOCS] Document priority based scratch directory selection

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17700 )

Change subject: IMPALA-10805: [DOCS] Document priority based scratch directory selection
......................................................................

IMPALA-10805: [DOCS] Document priority based scratch directory selection

Made minor changes.
Incorporated feedback received by providing more examples.
Explained how to configure priorities for the scratch directories.
Provided an example displaying priority based configuration.

Change-Id: Iec170fdefcde09d4ee99d06b0876a17eb0bde2f6
Reviewed-on: http://gerrit.cloudera.org:8080/17700
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_disk_space.xml
1 file changed, 39 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec170fdefcde09d4ee99d06b0876a17eb0bde2f6
Gerrit-Change-Number: 17700
Gerrit-PatchSet: 5
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-10805: [DOCS] Document priority based scratch directory selection

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17700 )

Change subject: IMPALA-10805: [DOCS] Document priority based scratch directory selection
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec170fdefcde09d4ee99d06b0876a17eb0bde2f6
Gerrit-Change-Number: 17700
Gerrit-PatchSet: 4
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Jul 2021 15:47:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10805: [DOCS] Document priority based scratch directory selection

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17700 )

Change subject: IMPALA-10805: [DOCS] Document priority based scratch directory selection
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/643/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/17700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec170fdefcde09d4ee99d06b0876a17eb0bde2f6
Gerrit-Change-Number: 17700
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Jul 2021 20:57:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10805: [DOCS] Document priority based scratch directory selection

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17700 )

Change subject: IMPALA-10805: [DOCS] Document priority based scratch directory selection
......................................................................


Patch Set 3: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/645/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/17700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec170fdefcde09d4ee99d06b0876a17eb0bde2f6
Gerrit-Change-Number: 17700
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 16:38:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10805: [DOCS] Document priority based scratch directory selection

Posted by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org>.
Hello Abhishek Rawat, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17700

to look at the new patch set (#2).

Change subject: IMPALA-10805: [DOCS] Document priority based scratch directory selection
......................................................................

IMPALA-10805: [DOCS] Document priority based scratch directory selection

Incorporated feedback received by providing more examples.
Explained how to configure priorities for the scratch directories.
Provided an example displaying priority based configuration.

Change-Id: Iec170fdefcde09d4ee99d06b0876a17eb0bde2f6
---
M docs/topics/impala_disk_space.xml
1 file changed, 33 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/17700/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iec170fdefcde09d4ee99d06b0876a17eb0bde2f6
Gerrit-Change-Number: 17700
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-10805: [DOCS] Document priority based scratch directory selection

Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17700 )

Change subject: IMPALA-10805: [DOCS] Document priority based scratch directory selection
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec170fdefcde09d4ee99d06b0876a17eb0bde2f6
Gerrit-Change-Number: 17700
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 16:35:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10805: [DOCS] Document priority based scratch directory selection

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17700 )

Change subject: IMPALA-10805: [DOCS] Document priority based scratch directory selection
......................................................................


Patch Set 2: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/644/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/17700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec170fdefcde09d4ee99d06b0876a17eb0bde2f6
Gerrit-Change-Number: 17700
Gerrit-PatchSet: 2
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 16:10:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10805: [DOCS] Document priority based scratch directory selection

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17700 )

Change subject: IMPALA-10805: [DOCS] Document priority based scratch directory selection
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec170fdefcde09d4ee99d06b0876a17eb0bde2f6
Gerrit-Change-Number: 17700
Gerrit-PatchSet: 4
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Jul 2021 15:54:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10805: [DOCS] Document priority based scratch directory selection

Posted by "Abhishek Rawat (Code Review)" <ge...@cloudera.org>.
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17700 )

Change subject: IMPALA-10805: [DOCS] Document priority based scratch directory selection
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17700/1/docs/topics/impala_disk_space.xml
File docs/topics/impala_disk_space.xml:

http://gerrit.cloudera.org:8080/#/c/17700/1/docs/topics/impala_disk_space.xml@300
PS1, Line 300:         &lt;dir-path&gt;
We can use actual values for dir, limit and priority like other examples.



-- 
To view, visit http://gerrit.cloudera.org:8080/17700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec170fdefcde09d4ee99d06b0876a17eb0bde2f6
Gerrit-Change-Number: 17700
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 05:17:11 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10805: [DOCS] Document priority based scratch directory selection

Posted by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org>.
Hello Abhishek Rawat, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17700

to look at the new patch set (#3).

Change subject: IMPALA-10805: [DOCS] Document priority based scratch directory selection
......................................................................

IMPALA-10805: [DOCS] Document priority based scratch directory selection

Made minor changes.
Incorporated feedback received by providing more examples.
Explained how to configure priorities for the scratch directories.
Provided an example displaying priority based configuration.

Change-Id: Iec170fdefcde09d4ee99d06b0876a17eb0bde2f6
---
M docs/topics/impala_disk_space.xml
1 file changed, 39 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/17700/3
-- 
To view, visit http://gerrit.cloudera.org:8080/17700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iec170fdefcde09d4ee99d06b0876a17eb0bde2f6
Gerrit-Change-Number: 17700
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>