You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spark.apache.org by ngbinh <gi...@git.apache.org> on 2014/02/28 00:52:55 UTC
[GitHub] spark pull request: Update io.netty from 4.0.13 Final to 4.0.17.Fi...
GitHub user ngbinh opened a pull request:
https://github.com/apache/spark/pull/41
Update io.netty from 4.0.13 Final to 4.0.17.Final
This update contains a lot of bug fixes and some new perf improvements.
It is also binary compatible with the current 4.0.13.Final
For more information: http://netty.io/news/2014/02/25/4-0-17-Final.html
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ngbinh/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/41.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #41
----
commit c782207f90cf66339268b5265b49b2e50a22a1a5
Author: Binh Nguyen <bn...@palantir.com>
Date: 2014-02-27T23:48:38Z
update io.netty to 4.0.17.Final
This update contains a lot of bug fixes and some new perf improvements.
It is also binary compatible with the current 4.0.13.Final
For more information: http://netty.io/news/2014/02/25/4-0-17-Final.html
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update io.netty from 4.0.13 Final to 4.0.17.Fi...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/41#issuecomment-36449064
Actually I'm having trouble merging this. I think it's because your git commit doesn't actually have any author information. Do you mind fixing that?
cc @pwendell here since he wrote that merge script
```
rxin @ rxin-mbp : /scratch/rxin/prs/spark-dev-tools/dev
> ./merge_spark_pr.py
Which pull request would you like to merge? (e.g. 34): 41
=== Pull Request #41 ===
title Update io.netty from 4.0.13 Final to 4.0.17.Final
source ngbinh/master
target master
url https://api.github.com/repos/apache/spark/pulls/41
Proceed with merging pull request #41? (y/n): y
Switched to branch 'PR_TOOL_MERGE_PR_41_MASTER'
fatal: No existing author found with '""'
Traceback (most recent call last):
File "./merge_spark_pr.py", line 197, in <module>
merge_hash = merge_pr(pr_num, target_ref)
File "./merge_spark_pr.py", line 114, in merge_pr
run_cmd(['git', 'commit', '--author="%s"' % primary_author] + merge_message_flags)
File "./merge_spark_pr.py", line 61, in run_cmd
return subprocess.check_output(cmd)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 575, in check_output
raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '['git', 'commit', '--author=""', '-m', u'Update io.netty from 4.0.13 Final to 4.0.17.Final', '-m', u'This update contains a lot of bug fixes and some new perf improvements.\r\nIt is also binary compatible with the current 4.0.13.Final\r\n\r\nFor more information: http://netty.io/news/2014/02/25/4-0-17-Final.html', '-m', 'Author: ', '-m', u'Closes #41 from ngbinh/master and squashes the following commits:', '-m', '']' returned non-zero exit status 128
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update io.netty from 4.0.13 Final to 4.0.17.Fi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/41#issuecomment-36306872
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update io.netty from 4.0.13 Final to 4.0.17.Fi...
Posted by ngbinh <gi...@git.apache.org>.
Github user ngbinh commented on the pull request:
https://github.com/apache/spark/pull/41#issuecomment-36449390
Yep, found the problem now. Should be fixed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update io.netty from 4.0.13 Final to 4.0.17.Fi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/41
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update io.netty from 4.0.13 Final to 4.0.17.Fi...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/41#issuecomment-36449234
Sorry @ngbinh you misunderstood me. I think the problem is the git commit metadata doesn't actually contain the author information. It could be that the email or the author info in the git commit itself is not set (it's not about the commit message).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update io.netty from 4.0.13 Final to 4.0.17.Fi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/41#issuecomment-36306871
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update io.netty from 4.0.13 Final to 4.0.17.Fi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/41#issuecomment-36306883
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update io.netty from 4.0.13 Final to 4.0.17.Fi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/41#issuecomment-36308968
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update io.netty from 4.0.13 Final to 4.0.17.Fi...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/41#issuecomment-36449397
Thanks. I've merged this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update io.netty from 4.0.13 Final to 4.0.17.Fi...
Posted by ngbinh <gi...@git.apache.org>.
Github user ngbinh commented on the pull request:
https://github.com/apache/spark/pull/41#issuecomment-36449199
just add Author to both PR and the commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update io.netty from 4.0.13 Final to 4.0.17.Fi...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/41#issuecomment-36449019
Thanks. I've merged this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update io.netty from 4.0.13 Final to 4.0.17.Fi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/41#issuecomment-36308969
All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12923/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---