You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by marcaurele <gi...@git.apache.org> on 2016/11/29 13:30:36 UTC
[GitHub] cloudstack pull request #1798: API: affinitygroupids or affinitygroupnames m...
GitHub user marcaurele opened a pull request:
https://github.com/apache/cloudstack/pull/1798
API: affinitygroupids or affinitygroupnames must be given
Return an exception if both parameter are missing.
Signed-off-by: Marc-Aur�le Brothier <m...@brothier.org>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/exoscale/cloudstack fix/CLOUDSTACK-9631
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1798.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1798
----
commit 907c46ae73bd5f5f4a7182c38665ccc64b62a3c4
Author: Marc-Aur�le Brothier <m...@brothier.org>
Date: 2016-11-29T12:54:28Z
API: affinitygroupids or affinitygroupnames must be given
Return an exception if both parameter are missing.
Signed-off-by: Marc-Aur�le Brothier <m...@brothier.org>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1798: CLOUDSTACK-9631: API: affinitygroupids or aff...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1798#discussion_r90372709
--- Diff: api/src/org/apache/cloudstack/api/command/user/affinitygroup/UpdateVMAffinityGroupCmd.java ---
@@ -96,6 +96,10 @@ public Long getId() {
throw new InvalidParameterValueException("affinitygroupids parameter is mutually exclusive with affinitygroupnames parameter");
}
+ if (affinityGroupNameList == null && affinityGroupIdList == null) {
+ throw new InvalidParameterValueException("affinitygroupids parameter or affinitygroupnames parameter must be given");
+ }
+
--- End diff --
Lines 95-102 should be at the beginning of the `execute` method rather than in an accessor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1798: CLOUDSTACK-9631: API: affinitygroupids or affinitygr...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1798
@marcaurele one of the component tests have failed, please have a look and/or push -f to rekick Travis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1798: CLOUDSTACK-9631: API: affinitygroupids or affinitygr...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1798
@marcaurele there appear to be Travis failures. Could you please check into them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1798: CLOUDSTACK-9631: API: affinitygroupids or affinitygr...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1798
@marcaurele please push -f on the PR to re-kick travis, or close/open the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---