You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2017/06/05 15:51:07 UTC
[kudu-CR] WIP Don't suicide on EIO
David Ribeiro Alves has posted comments on this change.
Change subject: WIP Don't suicide on EIO
......................................................................
Patch Set 11:
(2 comments)
had some old comments, feel free to ignore if no longer relevant.
did the contents of this patch end up somewhere else?
http://gerrit.cloudera.org:8080/#/c/6773/3/src/kudu/fs/block_manager.h
File src/kudu/fs/block_manager.h:
PS3, Line 48: FsErrorMan
maybe EioHandler or EioHandlerManager would be a better name>
Line 135: virtual Status FlushDataAsync() = 0;
spurious change
--
To view, visit http://gerrit.cloudera.org:8080/6773
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c221a5ea97c7b7ec5f8d395b5527dc16e63f828
Gerrit-PatchSet: 11
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes