You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by "Justin Mclean (JIRA)" <ji...@apache.org> on 2013/03/11 01:33:13 UTC
[jira] [Updated] (FLEX-33386) Style Declaration Matching Tuning -
Inlining
[ https://issues.apache.org/jira/browse/FLEX-33386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Mclean updated FLEX-33386:
---------------------------------
Labels: Performance easyfix (was: Performance)
> Style Declaration Matching Tuning - Inlining
> --------------------------------------------
>
> Key: FLEX-33386
> URL: https://issues.apache.org/jira/browse/FLEX-33386
> Project: Apache Flex
> Issue Type: Improvement
> Components: Styles
> Reporter: RJ Camarillo
> Assignee: Frédéric THOMAS
> Priority: Minor
> Labels: Performance, easyfix
> Fix For: Adobe Flex SDK Next
>
> Attachments: mx.styles - inlined.zip
>
>
> One of the most executed calls during the lifetime of a Flex UIComponent is the matching of style declarations (i.e. state change, component initialization, etc).
> As such, it is one that the community has monkey-patched often in order to attain speed-ups even for just a little.
> This is one of the improvements done to achieve that end. Instead of doing method calls to the different style classes (i.e. CSSCondition, CSSSelector, CSSStyleDeclaration), the StyleProtoChain class has been modified to perform matching inline as much as possible.
> The implementation is not perfect and I'm sure it can be improved further with the help of the bigger community. For example, the matchingDecls.sortOn("selectorIndex", Array.NUMERIC) call could be improve to use one of the faster sort algorithms out there. There are also some methods calls that are not inlined.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Updated] (FLEX-33386) Style Declaration Matching Tuning - Inlining
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> That's 5 classes, I have to check line by line to have the all logic in mind, I would have already done it if a it was a patch provided instead of complete classes.
Then ask them to supply a patch especially for than number of class.
Justin
Re: [jira] [Updated] (FLEX-33386) Style Declaration Matching Tuning - Inlining
Posted by Frédéric THOMAS <we...@hotmail.com>.
That's 5 classes, I have to check line by line to have the all logic in
mind, I would have already done it if a it was a patch provided instead of
complete classes.
-----Message d'origine-----
From: Frédéric THOMAS
Sent: Monday, March 11, 2013 2:32 AM
To: dev@flex.apache.org
Subject: Re: [jira] [Updated] (FLEX-33386) Style Declaration Matching
Tuning - Inlining
Not only, first, it's not a patch and it is based on the 4.6, IIRC and I
really have to check if there's no errors, good logic, if the perfs are
improved and the all tests passes
-----Message d'origine-----
From: Justin Mclean
Sent: Monday, March 11, 2013 2:25 AM
To: dev@flex.apache.org
Subject: Re: [jira] [Updated] (FLEX-33386) Style Declaration Matching
Tuning - Inlining
Hi
> Not so easy, many things to do but, yes, too long time on my list, I'll
> see that this week
Only if you have time, we need to spread the load a little. I believe in
this case a fix has been provided it just needs to be applied.
Thanks,
Justin
Re: [jira] [Updated] (FLEX-33386) Style Declaration Matching Tuning - Inlining
Posted by Frédéric THOMAS <we...@hotmail.com>.
Not only, first, it's not a patch and it is based on the 4.6, IIRC and I
really have to check if there's no errors, good logic, if the perfs are
improved and the all tests passes
-----Message d'origine-----
From: Justin Mclean
Sent: Monday, March 11, 2013 2:25 AM
To: dev@flex.apache.org
Subject: Re: [jira] [Updated] (FLEX-33386) Style Declaration Matching
Tuning - Inlining
Hi
> Not so easy, many things to do but, yes, too long time on my list, I'll
> see that this week
Only if you have time, we need to spread the load a little. I believe in
this case a fix has been provided it just needs to be applied.
Thanks,
Justin
Re: [jira] [Updated] (FLEX-33386) Style Declaration Matching Tuning - Inlining
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi
> Not so easy, many things to do but, yes, too long time on my list, I'll see that this week
Only if you have time, we need to spread the load a little. I believe in this case a fix has been provided it just needs to be applied.
Thanks,
Justin
Re: [jira] [Updated] (FLEX-33386) Style Declaration Matching Tuning - Inlining
Posted by Frédéric THOMAS <we...@hotmail.com>.
Not so easy, many things to do but, yes, too long time on my list, I'll see
that this week
-----Message d'origine-----
From: Justin Mclean (JIRA)
Sent: Monday, March 11, 2013 1:33 AM
To: dev@flex.apache.org
Subject: [jira] [Updated] (FLEX-33386) Style Declaration Matching Tuning -
Inlining
[
https://issues.apache.org/jira/browse/FLEX-33386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Mclean updated FLEX-33386:
---------------------------------
Labels: Performance easyfix (was: Performance)
> Style Declaration Matching Tuning - Inlining
> --------------------------------------------
>
> Key: FLEX-33386
> URL: https://issues.apache.org/jira/browse/FLEX-33386
> Project: Apache Flex
> Issue Type: Improvement
> Components: Styles
> Reporter: RJ Camarillo
> Assignee: Frédéric THOMAS
> Priority: Minor
> Labels: Performance, easyfix
> Fix For: Adobe Flex SDK Next
>
> Attachments: mx.styles - inlined.zip
>
>
> One of the most executed calls during the lifetime of a Flex UIComponent
> is the matching of style declarations (i.e. state change, component
> initialization, etc).
> As such, it is one that the community has monkey-patched often in order to
> attain speed-ups even for just a little.
> This is one of the improvements done to achieve that end. Instead of doing
> method calls to the different style classes (i.e. CSSCondition,
> CSSSelector, CSSStyleDeclaration), the StyleProtoChain class has been
> modified to perform matching inline as much as possible.
> The implementation is not perfect and I'm sure it can be improved further
> with the help of the bigger community. For example, the
> matchingDecls.sortOn("selectorIndex", Array.NUMERIC) call could be improve
> to use one of the faster sort algorithms out there. There are also some
> methods calls that are not inlined.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA
administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira