You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/09 04:00:33 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32030: [SPARK-34989] Improve the performance of mapChildren and withNewChildren methods

dongjoon-hyun commented on a change in pull request #32030:
URL: https://github.com/apache/spark/pull/32030#discussion_r610327961



##########
File path: mllib/src/main/scala/org/apache/spark/ml/stat/Summarizer.scala
##########
@@ -349,8 +349,7 @@ private[spark] object SummaryBuilderImpl extends Logging {
       weightExpr: Expression,
       mutableAggBufferOffset: Int,
       inputAggBufferOffset: Int)
-    extends TypedImperativeAggregate[SummarizerBuffer]
-    with ImplicitCastInputTypes
+    extends TypedImperativeAggregate[SummarizerBuffer] with ImplicitCastInputTypes

Review comment:
       Could you revert these two line change, @dbaliafroozeh ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org