[GitHub] [pulsar] 315157973 commented on a diff in pull request #19559: [fix][broker] Remove useless load balancer items about MemoryResourceWeight

["315157973 (via GitHub)" <gi...@apache.org>]

315157973 commented on code in PR #19559:
URL: https://github.com/apache/pulsar/pull/19559#discussion_r1116554930


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ThresholdShedder.java:
##########
@@ -168,7 +168,7 @@ private double updateAvgResourceUsage(String broker, LocalBrokerData localBroker
                 brokerAvgResourceUsage.get(broker);
         double resourceUsage = localBrokerData.getMaxResourceUsageWithWeight(
                 conf.getLoadBalancerCPUResourceWeight(),
-                conf.getLoadBalancerMemoryResourceWeight(), conf.getLoadBalancerDirectMemoryResourceWeight(),

Review Comment:
   The client module depends on the pulsar-common module, so the language level is still at 1.8, and we can not set `since` of Deprecated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org