[impala] 02/02: Run test_row_validation only on HDFS

[jo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit b8496d56e49814c36edadbff17b80b10bf40a3a2
Author: Zoltan Borok-Nagy <bo...@cloudera.com>
AuthorDate: Wed May 27 11:10:59 2020 +0200

    Run test_row_validation only on HDFS
    
    Added pytest.skip() when the test is being run on a filesystem other
    than HDFS. The test only makes sense on filesystems that support APPEND
    because it simulates Hive Streaming V2. And currently Hive Streaming
    only works on HDFS.
    
    Change-Id: Id2a647ba5c75a600f177f82290241a93afc71ea7
    Reviewed-on: http://gerrit.cloudera.org:8080/15988
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/query_test/test_acid_row_validation.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tests/query_test/test_acid_row_validation.py b/tests/query_test/test_acid_row_validation.py
index c6438c0..041e754 100644
--- a/tests/query_test/test_acid_row_validation.py
+++ b/tests/query_test/test_acid_row_validation.py
@@ -18,11 +18,12 @@
 # Functional tests for ACID integration with Hive.
 
 import os
+import pytest
 
 from tests.common.impala_test_suite import ImpalaTestSuite
 from tests.common.skip import SkipIfLocal
 from tests.util.acid_txn import AcidTxn
-
+from tests.util.filesystem_utils import IS_HDFS
 
 # Tests that Impala validates rows against a validWriteIdList correctly.
 class TestAcidRowValidation(ImpalaTestSuite):
@@ -63,6 +64,10 @@ class TestAcidRowValidation(ImpalaTestSuite):
     """Tests reading from a file written by Hive Streaming Ingestion. In the first no rows
     are valid. Then we commit the first transaction and read the table. Then we commit the
     last transaction and read the table."""
+    # This test only makes sense on a filesystem that supports the file append operation
+    # (e.g. S3 doesn't) because it simulates Hive Streaming V2. So let's run it only on
+    # HDFS.
+    if not IS_HDFS: pytest.skip()
     tbl_name = "streaming"
     self._create_test_table(vector, unique_database, tbl_name)
     self.run_test_case('QueryTest/acid-row-validation-0', vector, use_db=unique_database)