You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/02/20 23:28:13 UTC

[GitHub] [commons-statistics] mmalenic commented on pull request #26: Add truncated normal distribution.

mmalenic commented on pull request #26:
URL: https://github.com/apache/commons-statistics/pull/26#issuecomment-782765017


   Hi Alex, thanks for the feedback, I've implemented those changes.
   
   I was thinking about the test class as well and while I was writing it I was attempting to use parameterized tests, however I wasn't able to come up with an elegant solution. Perhaps the abstract base class could somehow use parameterized tests?
   
   In terms of adding distribution exceptions, how do you feel about adding a similar exception here: 
   https://github.com/apache/commons-statistics/blob/1339b4ce6e1111217525bee893f1365b93a68acf/commons-statistics-distribution/src/main/java/org/apache/commons/statistics/distribution/TruncatedNormalDistribution.java#L66-L68
   Which indicates that the condition is too large or equal to?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org