Re: svn commit: r18194 - in trunk/subversion: include libsvn_client libsvn_subr svn

["D.J. Heap" <dj...@gmail.com>]

On 1/23/06, lundblad@tigris.org <lu...@tigris.org> wrote:
> Author: lundblad
> Date: Mon Jan 23 04:52:29 2006
> New Revision: 18194
[sinp]
>
> Log:
> Fix issue #1809: Replace svn_client_ls and make recursive ls streamy.  Make it
> possible to determine if the target of an svn_client_list is a file or
> directory by always including the listed target dirent in the result.
[sinp]


I believe there is a pool lifetime issue with the path name when using
the old list functions -- I get strange/erratic results unless I tweak
the store_entries function to dupe the path into the lb->pool before
it is set as the hash key.  Attached is an obvious quickie-patch, but
I'm not sure it's the most correct.

DJ

Re: svn commit: r18194 - in trunk/subversion: include libsvn_client libsvn_subr svn

["Peter N. Lundblad" <pe...@famlundblad.se>]

On Tue, 24 Jan 2006, D.J. Heap wrote:

> On 1/23/06, lundblad@tigris.org <lu...@tigris.org> wrote:
> > Author: lundblad
> > Date: Mon Jan 23 04:52:29 2006
> > New Revision: 18194
> [sinp]
> >
> > Log:
> > Fix issue #1809: Replace svn_client_ls and make recursive ls streamy.  Make it
> > possible to determine if the target of an svn_client_list is a file or
> > directory by always including the listed target dirent in the result.
> [sinp]
>
>
> I believe there is a pool lifetime issue with the path name when using
> the old list functions -- I get strange/erratic results unless I tweak
> the store_entries function to dupe the path into the lb->pool before
> it is set as the hash key.  Attached is an obvious quickie-patch, but
> I'm not sure it's the most correct.

Obviously, yes! Thanks for catching. Would you mind committing that? (I
have another patch in my WC currently, but I can do it if you don't.)

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org