You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "David Jencks (JIRA)" <de...@geronimo.apache.org> on 2005/07/27 03:05:22 UTC

[jira] Created: (GERONIMO-820) CommandSupport does not adequately synchronize access to "state"

CommandSupport does not adequately synchronize access to "state"
----------------------------------------------------------------

         Key: GERONIMO-820
         URL: http://issues.apache.org/jira/browse/GERONIMO-820
     Project: Geronimo
        Type: Bug
  Components: deployment  
    Versions: 1.0-M4, 1.0-M5    
    Reporter: David Jencks
 Assigned to: David Jencks 
     Fix For: 1.0-M4, 1.0-M5


Changing state is synchronized, reading it should be also.

-    public DeploymentStatus getDeploymentStatus() {
+    public synchronized DeploymentStatus getDeploymentStatus() {
         return new Status(command, action, state, message);
     }
 


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (GERONIMO-820) CommandSupport does not adequately synchronize access to "state"

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-820?page=all ]
     
David Jencks closed GERONIMO-820:
---------------------------------

    Resolution: Fixed

Fixed, in CommandSupport
M5 rev 225439
M4 rev 225438

> CommandSupport does not adequately synchronize access to "state"
> ----------------------------------------------------------------
>
>          Key: GERONIMO-820
>          URL: http://issues.apache.org/jira/browse/GERONIMO-820
>      Project: Geronimo
>         Type: Bug
>   Components: deployment
>     Versions: 1.0-M4, 1.0-M5
>     Reporter: David Jencks
>     Assignee: David Jencks
>      Fix For: 1.0-M4, 1.0-M5

>
> Changing state is synchronized, reading it should be also.
> -    public DeploymentStatus getDeploymentStatus() {
> +    public synchronized DeploymentStatus getDeploymentStatus() {
>          return new Status(command, action, state, message);
>      }
>  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira