[GitHub] [druid] gianm commented on a change in pull request #9429: fix issue when distinct grouping dimensions are optimized into the same virtual column expression

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #9429: fix issue when distinct grouping dimensions are optimized into the same virtual column expression
URL: https://github.com/apache/druid/pull/9429#discussion_r385254202
 
 

 ##########
 File path: sql/src/main/java/org/apache/druid/sql/calcite/aggregation/DimensionExpression.java
 ##########
 @@ -38,11 +39,27 @@ public DimensionExpression(
       final ValueType outputType
   )
   {
+    this(outputName, outputName, expression, outputType);
+  }
+
+  public DimensionExpression(
 
 Review comment:
   It's not immediately clear when each constructor should be used. They need javadocs, or to be made private and replaced with nicely-named static factories, or (IMO ideally) both.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org