You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Allen Reese (JIRA)" <ji...@apache.org> on 2011/07/21 00:41:57 UTC
[jira] [Created] (AMQ-3410) AbstractAmqCommand should allow the
connection factory to be changed.
AbstractAmqCommand should allow the connection factory to be changed.
---------------------------------------------------------------------
Key: AMQ-3410
URL: https://issues.apache.org/jira/browse/AMQ-3410
Project: ActiveMQ
Issue Type: Improvement
Components: Broker
Affects Versions: 5.5.0
Reporter: Allen Reese
Priority: Minor
AbstractAmqCommand only allows an ActiveMQConnectionFactory to be used. I've got a custom factory that I would like to be able to use from the command line interface.
I'd like to see:
get/setFactory implemented on AbstractAmqCommand, as well as some sort of method to override the connection factory being used. I'm thinking along the lines of:
--factory com.yahoo.activemq.YahooActiveMQConnectionFactory
Then if the --factory option is set, then this class will be implemented and used, otherwise ActiveMQConnectionFactory.
I'll attach a patch shortly for this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (AMQ-3410) AbstractAmqCommand should allow the
connection factory to be changed.
Posted by "Allen Reese (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Allen Reese reopened AMQ-3410:
------------------------------
Reopening, it seems the test cases didn't make it in either AMQ-3404 or AMQ-3410.
[areese@spacepeople:jni activemq-trunk]$ svn info
Path: .
URL: http://svn.apache.org/repos/asf/activemq/trunk
Repository Root: http://svn.apache.org/repos/asf
Repository UUID: 13f79535-47bb-0310-9956-ffa450edef68
Revision: 1149274
Node Kind: directory
Schedule: normal
Last Changed Author: dejanb
Last Changed Rev: 1149097
Last Changed Date: 2011-07-21 03:19:42 -0700 (Thu, 21 Jul 2011)
[areese@spacepeople:jni activemq-trunk]$ svn status
? activemq-console/log
A activemq-console/src/test/java/org/apache/activemq/console
A activemq-console/src/test/java/org/apache/activemq/console/command
A activemq-console/src/test/java/org/apache/activemq/console/command/TestPurgeCommand.java
A activemq-console/src/test/java/org/apache/activemq/console/command/TestAMQ3410.java
[areese@spacepeople:jni activemq-trunk]$
> AbstractAmqCommand should allow the connection factory to be changed.
> ---------------------------------------------------------------------
>
> Key: AMQ-3410
> URL: https://issues.apache.org/jira/browse/AMQ-3410
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 5.5.0
> Reporter: Allen Reese
> Assignee: Dejan Bosanac
> Priority: Minor
> Fix For: 5.6.0
>
> Attachments: AMQ-3410.patch
>
>
> AbstractAmqCommand only allows an ActiveMQConnectionFactory to be used. I've got a custom factory that I would like to be able to use from the command line interface.
> I'd like to see:
> get/setFactory implemented on AbstractAmqCommand, as well as some sort of method to override the connection factory being used. I'm thinking along the lines of:
> --factory com.yahoo.activemq.YahooActiveMQConnectionFactory
> Then if the --factory option is set, then this class will be implemented and used, otherwise ActiveMQConnectionFactory.
> I'll attach a patch shortly for this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (AMQ-3410) AbstractAmqCommand should allow the
connection factory to be changed.
Posted by "Allen Reese (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Allen Reese closed AMQ-3410.
----------------------------
This works for me, and is complete.
> AbstractAmqCommand should allow the connection factory to be changed.
> ---------------------------------------------------------------------
>
> Key: AMQ-3410
> URL: https://issues.apache.org/jira/browse/AMQ-3410
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 5.5.0
> Reporter: Allen Reese
> Assignee: Dejan Bosanac
> Priority: Minor
> Fix For: 5.6.0
>
> Attachments: AMQ-3410.patch, AMQ-3410_add_tests.patch
>
>
> AbstractAmqCommand only allows an ActiveMQConnectionFactory to be used. I've got a custom factory that I would like to be able to use from the command line interface.
> I'd like to see:
> get/setFactory implemented on AbstractAmqCommand, as well as some sort of method to override the connection factory being used. I'm thinking along the lines of:
> --factory com.yahoo.activemq.YahooActiveMQConnectionFactory
> Then if the --factory option is set, then this class will be implemented and used, otherwise ActiveMQConnectionFactory.
> I'll attach a patch shortly for this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-3410) AbstractAmqCommand should allow the
connection factory to be changed.
Posted by "Allen Reese (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Allen Reese updated AMQ-3410:
-----------------------------
Attachment: AMQ-3410_add_tests.patch
A patch to add tests for AMQ-3404 and AMQ-3410
> AbstractAmqCommand should allow the connection factory to be changed.
> ---------------------------------------------------------------------
>
> Key: AMQ-3410
> URL: https://issues.apache.org/jira/browse/AMQ-3410
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 5.5.0
> Reporter: Allen Reese
> Assignee: Dejan Bosanac
> Priority: Minor
> Fix For: 5.6.0
>
> Attachments: AMQ-3410.patch, AMQ-3410_add_tests.patch
>
>
> AbstractAmqCommand only allows an ActiveMQConnectionFactory to be used. I've got a custom factory that I would like to be able to use from the command line interface.
> I'd like to see:
> get/setFactory implemented on AbstractAmqCommand, as well as some sort of method to override the connection factory being used. I'm thinking along the lines of:
> --factory com.yahoo.activemq.YahooActiveMQConnectionFactory
> Then if the --factory option is set, then this class will be implemented and used, otherwise ActiveMQConnectionFactory.
> I'll attach a patch shortly for this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-3410) AbstractAmqCommand should allow the
connection factory to be changed.
Posted by "Allen Reese (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Allen Reese updated AMQ-3410:
-----------------------------
Patch Info: [Patch Available]
> AbstractAmqCommand should allow the connection factory to be changed.
> ---------------------------------------------------------------------
>
> Key: AMQ-3410
> URL: https://issues.apache.org/jira/browse/AMQ-3410
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 5.5.0
> Reporter: Allen Reese
> Priority: Minor
>
> AbstractAmqCommand only allows an ActiveMQConnectionFactory to be used. I've got a custom factory that I would like to be able to use from the command line interface.
> I'd like to see:
> get/setFactory implemented on AbstractAmqCommand, as well as some sort of method to override the connection factory being used. I'm thinking along the lines of:
> --factory com.yahoo.activemq.YahooActiveMQConnectionFactory
> Then if the --factory option is set, then this class will be implemented and used, otherwise ActiveMQConnectionFactory.
> I'll attach a patch shortly for this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3410) AbstractAmqCommand should allow the
connection factory to be changed.
Posted by "Allen Reese (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069225#comment-13069225 ]
Allen Reese commented on AMQ-3410:
----------------------------------
What happened here is the patch didn't result in the avn add:
svn add activemq-console/src/test/java/org/apache/activemq/console
> AbstractAmqCommand should allow the connection factory to be changed.
> ---------------------------------------------------------------------
>
> Key: AMQ-3410
> URL: https://issues.apache.org/jira/browse/AMQ-3410
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 5.5.0
> Reporter: Allen Reese
> Assignee: Dejan Bosanac
> Priority: Minor
> Fix For: 5.6.0
>
> Attachments: AMQ-3410.patch, AMQ-3410_add_tests.patch
>
>
> AbstractAmqCommand only allows an ActiveMQConnectionFactory to be used. I've got a custom factory that I would like to be able to use from the command line interface.
> I'd like to see:
> get/setFactory implemented on AbstractAmqCommand, as well as some sort of method to override the connection factory being used. I'm thinking along the lines of:
> --factory com.yahoo.activemq.YahooActiveMQConnectionFactory
> Then if the --factory option is set, then this class will be implemented and used, otherwise ActiveMQConnectionFactory.
> I'll attach a patch shortly for this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (AMQ-3410) AbstractAmqCommand should allow the
connection factory to be changed.
Posted by "Dejan Bosanac (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dejan Bosanac resolved AMQ-3410.
--------------------------------
Resolution: Fixed
Ah missed to add those. They're in now (svn rev 1149492). Thanks for spotting it.
> AbstractAmqCommand should allow the connection factory to be changed.
> ---------------------------------------------------------------------
>
> Key: AMQ-3410
> URL: https://issues.apache.org/jira/browse/AMQ-3410
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 5.5.0
> Reporter: Allen Reese
> Assignee: Dejan Bosanac
> Priority: Minor
> Fix For: 5.6.0
>
> Attachments: AMQ-3410.patch, AMQ-3410_add_tests.patch
>
>
> AbstractAmqCommand only allows an ActiveMQConnectionFactory to be used. I've got a custom factory that I would like to be able to use from the command line interface.
> I'd like to see:
> get/setFactory implemented on AbstractAmqCommand, as well as some sort of method to override the connection factory being used. I'm thinking along the lines of:
> --factory com.yahoo.activemq.YahooActiveMQConnectionFactory
> Then if the --factory option is set, then this class will be implemented and used, otherwise ActiveMQConnectionFactory.
> I'll attach a patch shortly for this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-3410) AbstractAmqCommand should allow the
connection factory to be changed.
Posted by "Allen Reese (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Allen Reese updated AMQ-3410:
-----------------------------
Attachment: AMQ-3410.patch
This patch adds a --factory command line arg.
It depends on the fixes to activemq-console/src/test/resources/activemq.xml
contained in the patch in AMQ-3404 to work
> AbstractAmqCommand should allow the connection factory to be changed.
> ---------------------------------------------------------------------
>
> Key: AMQ-3410
> URL: https://issues.apache.org/jira/browse/AMQ-3410
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 5.5.0
> Reporter: Allen Reese
> Priority: Minor
> Attachments: AMQ-3410.patch
>
>
> AbstractAmqCommand only allows an ActiveMQConnectionFactory to be used. I've got a custom factory that I would like to be able to use from the command line interface.
> I'd like to see:
> get/setFactory implemented on AbstractAmqCommand, as well as some sort of method to override the connection factory being used. I'm thinking along the lines of:
> --factory com.yahoo.activemq.YahooActiveMQConnectionFactory
> Then if the --factory option is set, then this class will be implemented and used, otherwise ActiveMQConnectionFactory.
> I'll attach a patch shortly for this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (AMQ-3410) AbstractAmqCommand should allow the
connection factory to be changed.
Posted by "Dejan Bosanac (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dejan Bosanac resolved AMQ-3410.
--------------------------------
Resolution: Fixed
Fix Version/s: 5.6.0
Assignee: Dejan Bosanac
Patch applied with svn revision 1149097. Thanks!
> AbstractAmqCommand should allow the connection factory to be changed.
> ---------------------------------------------------------------------
>
> Key: AMQ-3410
> URL: https://issues.apache.org/jira/browse/AMQ-3410
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 5.5.0
> Reporter: Allen Reese
> Assignee: Dejan Bosanac
> Priority: Minor
> Fix For: 5.6.0
>
> Attachments: AMQ-3410.patch
>
>
> AbstractAmqCommand only allows an ActiveMQConnectionFactory to be used. I've got a custom factory that I would like to be able to use from the command line interface.
> I'd like to see:
> get/setFactory implemented on AbstractAmqCommand, as well as some sort of method to override the connection factory being used. I'm thinking along the lines of:
> --factory com.yahoo.activemq.YahooActiveMQConnectionFactory
> Then if the --factory option is set, then this class will be implemented and used, otherwise ActiveMQConnectionFactory.
> I'll attach a patch shortly for this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira