You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/03 14:48:48 UTC
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #28107:
[SPARK-31334][SQL] Don't ResolveReference/ResolveMissingReference when
Filter condition with aggregate expression
AngersZhuuuu commented on a change in pull request #28107: [SPARK-31334][SQL] Don't ResolveReference/ResolveMissingReference when Filter condition with aggregate expression
URL: https://github.com/apache/spark/pull/28107#discussion_r403059648
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1393,7 +1393,24 @@ class Analyzer(
case q: LogicalPlan =>
Review comment:
> can we just add a case above it?
>
> ```
> case f: Filter if ResolveAggregateFunctions.containsAggregate(f.condition) => f
>
> case q: LogicalPlan =>
> ...
> ```
Changed, for containsAggregate() method, where I put it is better? or add a common interface for Resolve Reference
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org