You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by Glen Mazza <gl...@verizon.net> on 2007/09/21 13:14:02 UTC
Re: svn commit: r578027 - in /incubator/cxf/trunk:
integration/jca/src/main/java/org/apache/cxf/connector/
integration/jca/src/main/java/org/apache/cxf/jca/cxf/
integration/jca/src/test/java/org/apache/cxf/jca/cxf/
systests/src/test/java/org/apache/cxf/sys...
Am Freitag, den 21.09.2007, 09:12 +0000 schrieb ningjiang@apache.org:
> Author: ningjiang
> Date: Fri Sep 21 02:12:28 2007
> New Revision: 578027
>
> Added: incubator/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/cxf/Messages.properties
> URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/cxf/Messages.properties?rev=578027&view=auto
> ==============================================================================
> --- incubator/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/cxf/Messages.properties (added)
> +++ incubator/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/cxf/Messages.properties Fri Sep 21 02:12:28 2007
> @@ -0,0 +1,24 @@
> +#
> +#
> +# Licensed to the Apache Software Foundation (ASF) under one
> +# or more contributor license agreements. See the NOTICE file
> +# distributed with this work for additional information
> +# regarding copyright ownership. The ASF licenses this file
> +# to you under the Apache License, Version 2.0 (the
> +# "License"); you may not use this file except in compliance
> +# with the License. You may obtain a copy of the License at
> +#
> +# http://www.apache.org/licenses/LICENSE-2.0
> +#
> +# Unless required by applicable law or agreed to in writing,
> +# software distributed under the License is distributed on an
> +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> +# KIND, either express or implied. See the License for the
> +# specific language governing permissions and limitations
> +# under the License.
> +#
> +#
> +INTERFACE_IS_NULL = The interface parameter is null.
> +IS_NOT_AN_INTERFACE = The [{0}] is not an interface.
> +FAIL_TO_GET_CXF_CONNECTION = Failed to get the CXF Connection with connection parameters : {0}
...with connection parameters: (no space between : and s)
> Modified: incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/cxf/ConnectionFactoryImplTest.java
> URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/cxf/ConnectionFactoryImplTest.java?rev=578027&r1=578026&r2=578027&view=diff
> ==============================================================================
> --- incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/cxf/ConnectionFactoryImplTest.java (original)
> +++ incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/cxf/ConnectionFactoryImplTest.java Fri Sep 21 02:12:28 2007
> @Test
> public void testInstanceOfReferencable() throws Exception {
> - ConnectionFactoryImpl cf = new ConnectionFactoryImpl(mockConnectionFactory,
> - mockConnectionManager);
> - assertTrue("instance of Referencable", cf instanceof Referenceable);
> + assertTrue("Instance of Referencable", cf instanceof Referenceable);
...of Referenceable
^
> Modified: incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/cxf/ManagedConnectionImplTest.java
> URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/cxf/ManagedConnectionImplTest.java?rev=578027&r1=578026&r2=578027&view=diff
> ==============================================================================
> --- incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/cxf/ManagedConnectionImplTest.java (original)
> +++ incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/cxf/ManagedConnectionImplTest.java Fri Sep 21 02:12:28 2007
> @Test
> public void testAssociateConnectionThrowsException() throws Throwable {
>
> -
> InvocationHandler ih = EasyMock.createMock(InvocationHandler.class);
>
> Object dodgyHandle = Proxy.newProxyInstance(getClass().getClassLoader(), new Class[] {Foo.class}, ih);
>
> try {
> mci.associateConnection(dodgyHandle);
> - fail("except exception on call with ClassCast Exception");
> + fail("Except exception on call with ClassCast Exception");
"Expecting an exception..."
^^^^
or (shorthand)
"Expect exception..."
Regards,
Glen
RE: svn commit: r578027 - in /incubator/cxf/trunk:integration/jca/src/main/java/org/apache/cxf/connector/integration/jca/src/main/java/org/apache/cxf/jca/cxf/integration/jca/src/test/java/org/apache/cxf/jca/cxf/systests/src/test/java/org/apache/cxf/sys...
Posted by "Jiang, Ning (Willem)" <Ni...@iona.com>.
Hi Glen,
Thanks, I just committed a quick fix for them.
Willem.
-----Original Message-----
From: Glen Mazza [mailto:glen.mazza@verizon.net]
Sent: Fri 9/21/2007 19:14
To: cxf-dev@incubator.apache.org
Subject: Re: svn commit: r578027 - in /incubator/cxf/trunk:integration/jca/src/main/java/org/apache/cxf/connector/integration/jca/src/main/java/org/apache/cxf/jca/cxf/integration/jca/src/test/java/org/apache/cxf/jca/cxf/systests/src/test/java/org/apache/cxf/sys...
Am Freitag, den 21.09.2007, 09:12 +0000 schrieb ningjiang@apache.org:
> Author: ningjiang
> Date: Fri Sep 21 02:12:28 2007
> New Revision: 578027
>
> Added: incubator/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/cxf/Messages.properties
> URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/cxf/Messages.properties?rev=578027&view=auto
> ==============================================================================
> --- incubator/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/cxf/Messages.properties (added)
> +++ incubator/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/cxf/Messages.properties Fri Sep 21 02:12:28 2007
> @@ -0,0 +1,24 @@
> +#
> +#
> +# Licensed to the Apache Software Foundation (ASF) under one
> +# or more contributor license agreements. See the NOTICE file
> +# distributed with this work for additional information
> +# regarding copyright ownership. The ASF licenses this file
> +# to you under the Apache License, Version 2.0 (the
> +# "License"); you may not use this file except in compliance
> +# with the License. You may obtain a copy of the License at
> +#
> +# http://www.apache.org/licenses/LICENSE-2.0
> +#
> +# Unless required by applicable law or agreed to in writing,
> +# software distributed under the License is distributed on an
> +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> +# KIND, either express or implied. See the License for the
> +# specific language governing permissions and limitations
> +# under the License.
> +#
> +#
> +INTERFACE_IS_NULL = The interface parameter is null.
> +IS_NOT_AN_INTERFACE = The [{0}] is not an interface.
> +FAIL_TO_GET_CXF_CONNECTION = Failed to get the CXF Connection with connection parameters : {0}
...with connection parameters: (no space between : and s)
> Modified: incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/cxf/ConnectionFactoryImplTest.java
> URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/cxf/ConnectionFactoryImplTest.java?rev=578027&r1=578026&r2=578027&view=diff
> ==============================================================================
> --- incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/cxf/ConnectionFactoryImplTest.java (original)
> +++ incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/cxf/ConnectionFactoryImplTest.java Fri Sep 21 02:12:28 2007
> @Test
> public void testInstanceOfReferencable() throws Exception {
> - ConnectionFactoryImpl cf = new ConnectionFactoryImpl(mockConnectionFactory,
> - mockConnectionManager);
> - assertTrue("instance of Referencable", cf instanceof Referenceable);
> + assertTrue("Instance of Referencable", cf instanceof Referenceable);
...of Referenceable
^
> Modified: incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/cxf/ManagedConnectionImplTest.java
> URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/cxf/ManagedConnectionImplTest.java?rev=578027&r1=578026&r2=578027&view=diff
> ==============================================================================
> --- incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/cxf/ManagedConnectionImplTest.java (original)
> +++ incubator/cxf/trunk/integration/jca/src/test/java/org/apache/cxf/jca/cxf/ManagedConnectionImplTest.java Fri Sep 21 02:12:28 2007
> @Test
> public void testAssociateConnectionThrowsException() throws Throwable {
>
> -
> InvocationHandler ih = EasyMock.createMock(InvocationHandler.class);
>
> Object dodgyHandle = Proxy.newProxyInstance(getClass().getClassLoader(), new Class[] {Foo.class}, ih);
>
> try {
> mci.associateConnection(dodgyHandle);
> - fail("except exception on call with ClassCast Exception");
> + fail("Except exception on call with ClassCast Exception");
"Expecting an exception..."
^^^^
or (shorthand)
"Expect exception..."
Regards,
Glen