You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2015/11/21 23:14:11 UTC
[jira] [Commented] (ZOOKEEPER-2329) Clear javac and javadoc warning
from zookeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020723#comment-15020723 ]
Hadoop QA commented on ZOOKEEPER-2329:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12773699/ZOOKEEPER-2329-01.patch
against trunk revision 1715577.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2964//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2964//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2964//console
This message is automatically generated.
> Clear javac and javadoc warning from zookeeper
> ----------------------------------------------
>
> Key: ZOOKEEPER-2329
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2329
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Arshad Mohammad
> Assignee: Arshad Mohammad
> Priority: Minor
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2329-01.patch
>
>
> Currently ZooKeeper java code has 10 javac and 1 javadoc warning. These should be removed.
> *javac warnings*
> {noformat}
> [javac] Compiling 228 source files to D:\gitHome\zookeeperTrunk\build\classes
> [javac] D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\ZooKeeperMain.java:226: warning: [rawtypes] found raw type: List
> [javac] List args = new LinkedList();
> [javac] ^
> [javac] missing type arguments for generic class List<E>
> [javac] where E is a type-variable:
> [javac] E extends Object declared in interface List
> [javac] D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\ZooKeeperMain.java:226: warning: [rawtypes] found raw type: LinkedList
> [javac] List args = new LinkedList();
> [javac] ^
> [javac] missing type arguments for generic class LinkedList<E>
> [javac] where E is a type-variable:
> [javac] E extends Object declared in class LinkedList
> [javac] D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\ZooKeeperMain.java:233: warning: [unchecked] unchecked call to add(E) as a member of the raw type List
> [javac] args.add(value);
> [javac] ^
> [javac] where E is a type-variable:
> [javac] E extends Object declared in interface List
> [javac] D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\ZooKeeperMain.java:239: warning: [unchecked] unchecked conversion
> [javac] cmdArgs = args;
> [javac] ^
> [javac] required: List<String>
> [javac] found: List
> [javac] D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\jmx\ManagedUtil.java:62: warning: [rawtypes] found raw type: Enumeration
> [javac] Enumeration enumer = r.getCurrentLoggers();
> [javac] ^
> [javac] missing type arguments for generic class Enumeration<E>
> [javac] where E is a type-variable:
> [javac] E extends Object declared in interface Enumeration
> [javac] D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\server\admin\AdminServer.java:33: warning: [serial] serializable class AdminServerException has no definition of serialVersionUID
> [javac] public class AdminServerException extends Exception {
> [javac] ^
> [javac] D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\server\admin\JettyAdminServer.java:142: warning: [serial] serializable class JettyAdminServer.CommandServlet has no definition of serialVersionUID
> [javac] private class CommandServlet extends HttpServlet {
> [javac] ^
> [javac] D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\server\util\KerberosUtil.java:39: warning: [rawtypes] found raw type: Class
> [javac] getInstanceMethod = classRef.getMethod("getInstance", new Class[0]);
> [javac] ^
> [javac] missing type arguments for generic class Class<T>
> [javac] where T is a type-variable:
> [javac] T extends Object declared in class Class
> [javac] D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\server\util\KerberosUtil.java:42: warning: [rawtypes] found raw type: Class
> [javac] new Class[0]);
> [javac] ^
> [javac] missing type arguments for generic class Class<T>
> [javac] where T is a type-variable:
> [javac] T extends Object declared in class Class
> [javac] D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\server\util\OSMXBean.java:89: warning: [rawtypes] found raw type: Class
> [javac] new Class[0]);
> [javac] ^
> [javac] missing type arguments for generic class Class<T>
> [javac] where T is a type-variable:
> [javac] T extends Object declared in class Class
> [javac] 10 warnings
> {noformat}
> *javadoc warning*
> {noformat}
> [javadoc] D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\server\PurgeTxnLog.java:172: warning - @return tag has no arguments.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)