[GitHub] [pinot] navina commented on pull request #10702: Support Deletes In Upserts

["navina (via GitHub)" <gi...@apache.org>]

navina commented on PR #10702:
URL: https://github.com/apache/pinot/pull/10702#issuecomment-1529399018

   > Thank you for highlighting this. I do not wish to go into details of our 1:1 conversation here -- but my understanding was that:
   > 
   > 1. You were planning on working this post May 10th.
   > 2. You mentioned that it would be hard for us to collaborate since we are in different timezones.
   > 3. I had mentioned that I have a patch I have been playing with -- and have a hard timeline.
   
   While all those are true, I told you that my design was open for feedback and you agreed to review it. 
   Obviously, I also have a local patch that I was working based on my design. Per Apache Pinot's guidelines (https://docs.pinot.apache.org/developers/developers-and-contributors/contribution-guidelines), I was taking ownership of the GitHub issue and sharing design for feedback. 
   
   > In this case, I only finished my PR since you mentioned that you will work on it post May 10th and would find it hard to collaborate with me -- which led me to think that our internal timelines might not be matched.
   
   You didn't communicate your timeline in our conversation nor did you explain the use-case when I asked. 
   
   I am not aware of how you communicated the handover of your group by issue to another contributor and I don't think it is relevant to the tasks I own.
   
   I have put in effort in this work and have shared my design ( https://docs.google.com/document/d/19s1AHCRjmqeVa0z_djYBTAt_meg6qWcUxwRO3y-G9O4/edit?usp=drivesdk ) and PR ( https://github.com/apache/pinot/pull/10703 )  for review. 
    Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org