You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by chenghao-intel <gi...@git.apache.org> on 2015/01/07 06:11:12 UTC
[GitHub] spark pull request: [SPARK-5009][SQL] Refactor the code of SQLPars...
GitHub user chenghao-intel opened a pull request:
https://github.com/apache/spark/pull/3924
[SPARK-5009][SQL] Refactor the code of SQLParser relevant code
Currently lots of duplicated source code for SQL Parser relevant, this PR aims to make a unified `AbstractSparkSQLParser`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chenghao-intel/spark sqlparser
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/3924.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3924
----
commit 958811083783fb7aa8a5b1b93a05cafd0deb4249
Author: Cheng Hao <ha...@intel.com>
Date: 2015-01-07T04:57:12Z
refactor the code of SQLParser relevant code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5009][SQL] Refactor the code of SQLPars...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3924#issuecomment-69030959
[Test build #25163 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25163/consoleFull) for PR 3924 at commit [`fb6ba9d`](https://github.com/apache/spark/commit/fb6ba9d4553201893ec38025f86468b41ecee031).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5009][SQL] Refactor the code of SQLPars...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3924#issuecomment-68987094
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25143/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5009][SQL] Refactor the code of SQLPars...
Posted by chenghao-intel <gi...@git.apache.org>.
Github user chenghao-intel closed the pull request at:
https://github.com/apache/spark/pull/3924
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5009][SQL] Refactor the code of SQLPars...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3924#issuecomment-68983138
[Test build #25143 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25143/consoleFull) for PR 3924 at commit [`9218922`](https://github.com/apache/spark/commit/9218922d71ba6617dba1665461ca32cedb29a554).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5009][SQL] Refactor the code of SQLPars...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3924#issuecomment-68987092
[Test build #25143 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25143/consoleFull) for PR 3924 at commit [`9218922`](https://github.com/apache/spark/commit/9218922d71ba6617dba1665461ca32cedb29a554).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class SqlLexical extends StdLexical `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5009][SQL] Refactor the code of SQLPars...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3924#issuecomment-69041997
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25163/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5009][SQL] Refactor the code of SQLPars...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3924#issuecomment-68979833
[Test build #25140 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25140/consoleFull) for PR 3924 at commit [`9588110`](https://github.com/apache/spark/commit/958811083783fb7aa8a5b1b93a05cafd0deb4249).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5009][SQL] Refactor the code of SQLPars...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3924#issuecomment-68980424
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25140/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5009][SQL] Refactor the code of SQLPars...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3924#issuecomment-68980420
[Test build #25140 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25140/consoleFull) for PR 3924 at commit [`9588110`](https://github.com/apache/spark/commit/958811083783fb7aa8a5b1b93a05cafd0deb4249).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class SqlLexical extends StdLexical `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5009][SQL] Refactor the code of SQLPars...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3924#issuecomment-69041987
[Test build #25163 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25163/consoleFull) for PR 3924 at commit [`fb6ba9d`](https://github.com/apache/spark/commit/fb6ba9d4553201893ec38025f86468b41ecee031).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class SqlLexical extends StdLexical `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org