[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #182: [FLINK-27708] Add background compaction task for append-only table when ingesting

[GitBox <gi...@apache.org>]

JingsongLi commented on code in PR #182:
URL: https://github.com/apache/flink-table-store/pull/182#discussion_r913336130


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/AbstractFileStoreScan.java:
##########
@@ -272,4 +272,15 @@ private boolean filterByBucket(ManifestEntry entry) {
     private List<ManifestEntry> readManifestFileMeta(ManifestFileMeta manifest) {
         return manifestFileFactory.create().read(manifest.fileName());
     }
+
+    private List<ManifestFileMeta> readIncremental(Long snapshotId) {

Review Comment:
   Why do this change?
   I think we can add a validation here `snapshot.commitKind() == Snapshot.CommitKind.APPEND`, but why a `while`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org