You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/17 08:10:23 UTC

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6872: risc-v/mpfs: ihc: don't use semaphores with OpenSBI vendor calls

pkarashchenko commented on code in PR #6872:
URL: https://github.com/apache/incubator-nuttx/pull/6872#discussion_r947586130


##########
arch/risc-v/src/mpfs/mpfs_ihc.c:
##########
@@ -177,8 +177,10 @@ static struct mpfs_rptun_shmem_s    g_shmem;
 static struct rpmsg_device         *g_mpfs_rpmsg_device;
 static struct rpmsg_virtio_device  *g_mpfs_virtio_device;
 
+#ifndef CONFIG_MPFS_OPENSBI
 static sem_t  g_mpfs_ack_sig       = SEM_INITIALIZER(0);
 static sem_t  g_mpfs_rx_sig        = SEM_INITIALIZER(0);

Review Comment:
   If those are signalling semaphores, then maybe it is better to switch to `NXSEM_INITIALIZER(0, PRIOINHERIT_FLAGS_DISABLE);`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org