You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/07/15 07:16:58 UTC

[GitHub] [skywalking] momo0313 commented on issue #4893: Why oap use the "stop" analyzer instead of "standand" one for the endpoint name field in elasticsearch storage?

momo0313 commented on issue #4893:
URL: https://github.com/apache/skywalking/issues/4893#issuecomment-658591759


   With some more research, the "pattern analyzer" may NOT be a good choice. As described in [pattern analyzer](https://www.elastic.co/guide/en/elasticsearch/reference/current/analysis-pattern-analyzer.html), it uses Java Regular Expressions. We have to think about the performance, further more, a badly written regular expression could run very slowly or even throw a StackOverflowError and cause the node it is running on to exit suddenly.
   
   Actually, I have not idea about this issue now, and I change my point of view to: The user should not have to know about the background knowledges of the analyzer of Elasticsearch, they just input the complete endpoint to query and then get the accurate result. Or we support the both by adding two query types, "fuzzy" or "accurate"


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org