You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/26 12:09:41 UTC

[jira] [Commented] (NIFI-3650) Ensure travis-ci won't cache nifi artifacts

    [ https://issues.apache.org/jira/browse/NIFI-3650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942257#comment-15942257 ] 

ASF GitHub Bot commented on NIFI-3650:
--------------------------------------

GitHub user trixpan opened a pull request:

    https://github.com/apache/nifi/pull/1625

    NIFI-3650 - Adjust travis to forcefuly remove $HOME/.m2/repository/or…

    …g/apache/nifi/
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [X] ~~~Have you written or updated unit tests to verify your changes?~~~
    - [X] ~~~If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?~~~ 
    - [X] ~~~If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?~~~
    - [X] ~~~If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?~~~
    - [X] ~~~If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?~~~
    
    ### For documentation related changes:
    - [X] ~~~Have you ensured that format looks appropriate for the output in which it is rendered?~~~
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/trixpan/nifi NIFI-3650

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1625.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1625
    
----
commit 08bfb15164f53713c63b6947af8572c7acdf03ff
Author: Andre F de Miranda <tr...@users.noreply.github.com>
Date:   2017-03-26T12:06:41Z

    NIFI-3650 - Adjust travis to forcefuly remove $HOME/.m2/repository/org/apache/nifi/

----


> Ensure travis-ci won't cache nifi artifacts
> -------------------------------------------
>
>                 Key: NIFI-3650
>                 URL: https://issues.apache.org/jira/browse/NIFI-3650
>             Project: Apache NiFi
>          Issue Type: Bug
>            Reporter: Andre F de Miranda
>            Assignee: Andre F de Miranda
>
> while caching dependencies is a fair way of improving travis-ci build times, the existence of cached NiFi artifacts within maven's ~/.m2 directory may hide issues caused by incomplete code refactoring that would otherwise be triggered had travis-ci been running a truly clean build.
> We should find a way of balancing caching and possible build false negatives.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)