You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@uniffle.apache.org by "vinayakmalik95 (via GitHub)" <gi...@apache.org> on 2023/03/14 09:55:47 UTC

[GitHub] [incubator-uniffle] vinayakmalik95 opened a new issue, #716: [Improvement] Need support for imagePullSecrets while applying full-restart full-upgrade or deploying coordinator or shuffle server

vinayakmalik95 opened a new issue, #716:
URL: https://github.com/apache/incubator-uniffle/issues/716

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What would you like to be improved?
   
   while applying the webhook.yaml under the Kind: Deployment
   
   I can use imagePullSecrets
   example:
   
   kind: Deployment
   apiVersion: apps/v1
   metadata:
   name: rss-webhook
   namespace: rss-system
   spec:
   strategy:
   rollingUpdate:
   maxSurge: 1
   maxUnavailable: 2
   type: RollingUpdate
   selector:
   matchLabels:
   app: rss-webhook
   replicas: 1
   template:
   metadata:
   labels:
   app: rss-webhook
   service: rss-webhook
   spec:
   serviceAccountName: rss-webhook
   containers:
   - name: rss-webhook
   image: xyz/rss-webhook:0.8.0-SNAPSHOT
   command:
   - "./webhook"
   args:
   - "--ignore-rss=false"
   - "--v=4"
   ports:
   - containerPort: 9876
   protocol: TCP
   imagePullPolicy: "Always"
   env:
   - name: POD_NAME
   valueFrom:
   fieldRef:
   apiVersion: v1
   fieldPath: metadata.name
   - name: POD_NAMESPACE
   valueFrom:
   fieldRef:
   apiVersion: v1
   fieldPath: metadata.namespace
   - name: NODE_NAME
   valueFrom:
   fieldRef:
   fieldPath: spec.nodeName
   resources:
   requests:
   cpu: 500m
   memory: 1024Mi
   **imagePullSecrets:**
   - name: container-registry
   tolerations:
   - effect: NoSchedule
   key: node-role.kubernetes.io/master
   affinity:
   podAntiAffinity:
   requiredDuringSchedulingIgnoredDuringExecution:
   - labelSelector:
   matchExpressions:
   - key: app
   operator: In
   values:
   - rss-webhook
   topologyKey: kubernetes.io/hostname
   
   **But while applying the full-upgrade or applying coordinator or shuffleServer there is no support of imagePullSecrets.**
   
   apiVersion: uniffle.apache.org/v1alpha1
   kind: RemoteShuffleService
   metadata:
   name: rss-full-upgrade-demo
   namespace: rss-system
   spec:
   configMapName: rss-configuration
   coordinator:
   image: rss-server:0.8.0
   initContainerImage: "busybox:latest"
   rpcNodePort:
   - 30001
   - 30011
   httpNodePort:
   - 30002
   - 30012
   xmxSize: "2G"
   count: 2
   configDir: "/data/rssadmin/rss/conf"
   replicas: 1
   excludeNodesFilePath: "/data/rssadmin/rss/coo/exclude_nodes"
   securityContext:
   runAsUser: 1000
   fsGroup: 1000
   logHostPath: "/data/logs/rss/coordinator"
   hostPathMounts:
   /data/logs/rss/coordinator: /data/rssadmin/rss/logs
   shuffleServer:
   sync: true
   replicas: 3
   image: rss-server:0.8.0-SNAPSHOT
   initContainerImage: "busybox:latest"
   upgradeStrategy:
   type: "FullUpgrade"
   xmxSize: "2G"
   configDir: "/data/rssadmin/rss/conf"
   securityContext:
   runAsUser: 1000
   fsGroup: 1000
   logHostPath: "/data/logs/rss/shuffle-server"
   hostPathMounts:
   /data/logs/rss/shuffle-server: /data/rssadmin/rss/logs
   /data/rssenv1/rssdata1: /data1
   /data/rssenv1/rssdata2: /data2
   /data/rssenv1/rssdata3: /data3
   
   ### How should we improve?
   
   giving support of imagePullSecrets in the CRD of uniffleremoteshuffleservices
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-uniffle] xianjingfeng closed issue #716: [Improvement] Need support for imagePullSecrets while applying full-restart full-upgrade or deploying coordinator or shuffle server

Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.

xianjingfeng closed issue #716: [Improvement] Need support for imagePullSecrets while applying full-restart full-upgrade or deploying coordinator or shuffle server
URL: https://github.com/apache/incubator-uniffle/issues/716


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-uniffle] vinayakmalik95 commented on issue #716: [Improvement] Need support for imagePullSecrets while applying full-restart full-upgrade or deploying coordinator or shuffle server

Posted by "vinayakmalik95 (via GitHub)" <gi...@apache.org>.

vinayakmalik95 commented on issue #716:
URL: https://github.com/apache/incubator-uniffle/issues/716#issuecomment-1467768903

   @wangao1236  @jerqi please find the details above.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org