You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2014/12/10 00:26:06 UTC

[GitHub] incubator-brooklyn pull request: BROOKLYN-101: avoid recordLocatio...

GitHub user aledsage opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/382

    BROOKLYN-101: avoid recordLocationEvent on rebind

    - Previously on rebind we would call recordLocationEvent, which would
      try to get `inferMachineDetails` over ssh in the rebind thread
      (taking a long time).
    - Now we don’t recordLocationEvent or recordApplicationEvent on
      startup or shutdown.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/incubator-brooklyn fix/brooklyn-101-rebind-sshing

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/382.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #382
    
----
commit 9447516ba1cdd78e13ded6867578330834ddd174
Author: Aled Sage <al...@gmail.com>
Date:   2014-12-09T23:24:49Z

    BROOKLYN-101: avoid recordLocationEvent on rebind
    
    - Previously on rebind we would call recordLocationEvent, which would
      try to get `inferMachineDetails` over ssh in the rebind thread
      (taking a long time).
    - Now we don’t recordLocationEvent or recordApplicationEvent on
      startup or shutdown.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: BROOKLYN-101: avoid recordLocatio...

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/382#issuecomment-67474691
  
    Thanks @nakomis - merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: BROOKLYN-101: avoid recordLocatio...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/382


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: BROOKLYN-101: avoid recordLocatio...

Posted by nakomis <gi...@git.apache.org>.

Github user nakomis commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/382#issuecomment-67474374
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---