You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/05/31 03:23:32 UTC
[GitHub] [incubator-mxnet] larroy commented on a change in pull request
#14836: [Don't merge][Don't review] Refactor AGInfo and Imperative
larroy commented on a change in pull request #14836: [Don't merge][Don't review] Refactor AGInfo and Imperative
URL: https://github.com/apache/incubator-mxnet/pull/14836#discussion_r289246136
##########
File path: include/mxnet/imperative.h
##########
@@ -35,48 +35,53 @@
#include "./ndarray.h"
namespace mxnet {
-/*! \brief runtime functions for NDArray */
-class Imperative {
+/*!
+ * Autograd Info used in class: nnvm::Node::info
+ */
+class AGInfo {
public:
- /*! \brief */
- class AGInfo {
- public:
- Context ctx;
- OpReqType grad_req;
- OpStatePtr state;
- std::vector<NDArray> outputs;
- std::vector<NDArray> out_grads;
- bool fresh_out_grad;
+ Context ctx;
Review comment:
Thanks, will fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services