You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "C0urante (via GitHub)" <gi...@apache.org> on 2023/02/16 20:00:53 UTC

[GitHub] [kafka] C0urante commented on pull request #13262: KAFKA-14727: Enable periodic offset commits for EOS source tasks

C0urante commented on PR #13262:
URL: https://github.com/apache/kafka/pull/13262#issuecomment-1433640900

   > This is covered by the existing `testPollReturnsNoRecords` where the two arguments to verifyTransactions are different.
   
   Ah yes, thanks. Sorry for missing that.
   
   > Also the tests uncovered a difference in behavior for `testSlowTaskStart`: If the task is started and then stopped before the start() method completes, the final task shutdown now calls commit().
   
   Good catch. I think this is reasonable considering it matches the behavior in non-EOS mode.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org