[GitHub] [airflow] potiuk commented on pull request #19257: fix: dag_id and task_id non ascii char

[GitBox <gi...@apache.org>]

potiuk commented on pull request #19257:
URL: https://github.com/apache/airflow/pull/19257#issuecomment-953125133


   There re tests failing @Melodie97 See the "Red" Some checks were not succesful and all the tests below - you will see some red-crosed failing tests. You should aim to get them all green. You can follow "Details" link for every failed test.
   
   Static checks particularly are running to verify a lot of "expectations" we have around the code automatically (Formatting, spelling and big (>70) number of others). They are run by `pre-commit` framework which is best you install locally - so that you can resolve the problems locally before you actually push code to the repo.
   
   Pre-commits are cool because they will suggest or even fix the problems for you automatically (so that you will have to add and commit them). 
   
   More info on static checks here (including explanations what happens and installation instructions and usage instructions for typical cases:
   https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst
   
   Also you have some unit tests failing and you need also to take a look at those and fix them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org