You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/25 11:54:11 UTC

[GitHub] [flink] dianfu edited a comment on pull request #13034: [FLINK-9992][tests] Fix FsStorageLocationReferenceTest#testEncodeAndDecode by adding retries to generate a valid path

dianfu edited a comment on pull request #13034:
URL: https://github.com/apache/flink/pull/13034#issuecomment-679978154


   @StephanEwen Thanks a lot for the review. I have updated the PR with the following changes:
   - Add the missing the ':' between host and port
   - Retry in a while loop until got a valid string. I prefer this option because I'm not confident that excluding "underscore, colon, whitespace" is enough. Considering that this is only used in test case, I think that retry should be enough.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org