You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/12/24 03:40:33 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5069: Improve dependencies for `dirlinks`.
xiaoxiang781216 commented on a change in pull request #5069:
URL: https://github.com/apache/incubator-nuttx/pull/5069#discussion_r774858470
##########
File path: tools/Makefile.unix
##########
@@ -524,9 +581,16 @@ config: apps_preconfig
$(Q) APPSDIR=${CONFIG_APPS_DIR} EXTERNALDIR=$(EXTERNALDIR) kconfig-conf Kconfig
oldconfig: apps_preconfig
+ echo $@
$(Q) APPSDIR=${CONFIG_APPS_DIR} EXTERNALDIR=$(EXTERNALDIR) kconfig-conf --oldconfig Kconfig
-olddefconfig: apps_preconfig
+# olddefconfig first needs to clear the context to ensure the configuration is up to date
+# and no old artifacts (i.e. symlinks) still exist. By setting .NOTPARALLEL we can enforce
+# order and ensure clean_context is executed first.
+
+.NOTPARALLEL: olddefconfig
+olddefconfig: clean_context apps_preconfig
+ echo $@
Review comment:
why need
##########
File path: tools/Makefile.unix
##########
@@ -524,9 +581,16 @@ config: apps_preconfig
$(Q) APPSDIR=${CONFIG_APPS_DIR} EXTERNALDIR=$(EXTERNALDIR) kconfig-conf Kconfig
oldconfig: apps_preconfig
+ echo $@
Review comment:
why need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org