You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Edward J. Yoon (JIRA)" <ji...@apache.org> on 2008/12/19 02:31:44 UTC

[jira] Created: (HAMA-140) In subMatrix(), Scanner should be closed.

In subMatrix(), Scanner should be closed.
-----------------------------------------

                 Key: HAMA-140
                 URL: https://issues.apache.org/jira/browse/HAMA-140
             Project: Hama
          Issue Type: Bug
          Components: implementation
    Affects Versions: 0.1.0
            Reporter: Edward J. Yoon
            Assignee: Edward J. Yoon
             Fix For: 0.1.0


  public SubMatrix subMatrix(int i0, int i1, int j0, int j1) throws IOException {
    Scanner scan = table.getScanner(cols, BytesUtil.getRowIndex(i0), 
        BytesUtil.getRowIndex(i1 + 1));
   +scan.close();
  }


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-140) In subMatrix(), Scanner should be closed.

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-140:
--------------------------------

    Attachment: HAMA-140.patch

> In subMatrix(), Scanner should be closed.
> -----------------------------------------
>
>                 Key: HAMA-140
>                 URL: https://issues.apache.org/jira/browse/HAMA-140
>             Project: Hama
>          Issue Type: Bug
>          Components: implementation
>    Affects Versions: 0.1.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>         Attachments: HAMA-140.patch
>
>
>   public SubMatrix subMatrix(int i0, int i1, int j0, int j1) throws IOException {
>     Scanner scan = table.getScanner(cols, BytesUtil.getRowIndex(i0), 
>         BytesUtil.getRowIndex(i1 + 1));
>    +scan.close();
>   }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-140) In subMatrix(), Scanner should be closed.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657968#action_12657968 ] 

Hudson commented on HAMA-140:
-----------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12396447/HAMA-140.patch
against trunk revision 727641.

    @author +1.  The patch does not contain any @author tags.

    tests included -1.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/136/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/136/artifact/trunk/build/reports/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/136/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/136/console

This message is automatically generated.

> In subMatrix(), Scanner should be closed.
> -----------------------------------------
>
>                 Key: HAMA-140
>                 URL: https://issues.apache.org/jira/browse/HAMA-140
>             Project: Hama
>          Issue Type: Bug
>          Components: implementation
>    Affects Versions: 0.1.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>         Attachments: HAMA-140.patch
>
>
>   public SubMatrix subMatrix(int i0, int i1, int j0, int j1) throws IOException {
>     Scanner scan = table.getScanner(cols, BytesUtil.getRowIndex(i0), 
>         BytesUtil.getRowIndex(i1 + 1));
>    +scan.close();
>   }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-140) In subMatrix(), Scanner should be closed.

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-140:
--------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Fixed.

> In subMatrix(), Scanner should be closed.
> -----------------------------------------
>
>                 Key: HAMA-140
>                 URL: https://issues.apache.org/jira/browse/HAMA-140
>             Project: Hama
>          Issue Type: Bug
>          Components: implementation
>    Affects Versions: 0.1.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>         Attachments: HAMA-140.patch
>
>
>   public SubMatrix subMatrix(int i0, int i1, int j0, int j1) throws IOException {
>     Scanner scan = table.getScanner(cols, BytesUtil.getRowIndex(i0), 
>         BytesUtil.getRowIndex(i1 + 1));
>    +scan.close();
>   }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-140) In subMatrix(), Scanner should be closed.

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-140:
--------------------------------

    Status: Patch Available  (was: Open)

Submit my patch.

> In subMatrix(), Scanner should be closed.
> -----------------------------------------
>
>                 Key: HAMA-140
>                 URL: https://issues.apache.org/jira/browse/HAMA-140
>             Project: Hama
>          Issue Type: Bug
>          Components: implementation
>    Affects Versions: 0.1.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.1.0
>
>         Attachments: HAMA-140.patch
>
>
>   public SubMatrix subMatrix(int i0, int i1, int j0, int j1) throws IOException {
>     Scanner scan = table.getScanner(cols, BytesUtil.getRowIndex(i0), 
>         BytesUtil.getRowIndex(i1 + 1));
>    +scan.close();
>   }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.