[GitHub] [spark] otterc commented on a change in pull request #33613: [SPARK-36378][SHUFFLE] Switch to using RPCResponse to communicate common block push failures to the client.

[GitBox <gi...@apache.org>]

otterc commented on a change in pull request #33613:
URL: https://github.com/apache/spark/pull/33613#discussion_r682333147



##########
File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java
##########
@@ -863,8 +884,8 @@ public void onComplete(String streamId) throws IOException {
         if (isStaleOrTooLate(appShuffleInfo.shuffles.get(partitionInfo.shuffleId),
             partitionInfo.shuffleMergeId, partitionInfo.reduceId)) {
           deferredBufs = null;
-          throw new RuntimeException(String.format("Block %s is %s", streamId,
-            ErrorHandler.BlockPushErrorHandler.TOO_LATE_OR_STALE_BLOCK_PUSH_MESSAGE_SUFFIX));
+          throw new RuntimeException("Block " + streamId + " " +

Review comment:
       @Victsm there is still another instance in `RemoteBlockPushResolver` that throws `StaleBlockPushException` 
   ```
               throw new StaleBlockPushException(String.format("Rejecting shuffle blocks push request"
                 + " for shuffle %s with shuffleMergeId %s for application %s_%s as a higher"
                 + " shuffleMergeId %s request is already seen", shuffleId, shuffleMergeId,
                 appShuffleInfo.appId, appShuffleInfo.attemptId, latestShuffleMergeId));
    ```
    




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org