You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2014/04/09 11:38:40 UTC

Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template creation from user VM volume, added method to check the state of VM before template creation

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/#review39871
-----------------------------------------------------------


Santhosh, can you please review this? Review changes have been incorporated.

- Ashutosh Kelkar


On March 21, 2014, 2:28 p.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19399/
> -----------------------------------------------------------
> 
> (Updated March 21, 2014, 2:28 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6257
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6257
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_project_usage.py ba0a63c 
>   test/integration/component/test_resource_limits.py f0d558e 
>   test/integration/component/test_tags.py 2a6e076 
>   test/integration/component/test_templates.py 3e83615 
>   test/integration/component/test_usage.py 5979a0a 
>   tools/marvin/marvin/codes.py e4a0f6a 
>   tools/marvin/marvin/integration/lib/base.py 775b289 
> 
> Diff: https://reviews.apache.org/r/19399/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>