You are viewing a plain text version of this content. The canonical link for it is here.
Posted to sandesha-dev@ws.apache.org by ga...@apache.org on 2007/09/25 16:35:44 UTC

svn commit: r579262 - /webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/SenderWorker.java

Author: gatfora
Date: Tue Sep 25 07:35:44 2007
New Revision: 579262

URL: http://svn.apache.org/viewvc?rev=579262&view=rev
Log:
Undo changes made to SenderWorker as this breaks the Sandesha unit tests.  The particular case broken is when a sync ack is sent on an Async request/response, the OpContext was being completed so no async response would ever be sent

Modified:
    webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/SenderWorker.java

Modified: webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/SenderWorker.java
URL: http://svn.apache.org/viewvc/webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/SenderWorker.java?rev=579262&r1=579261&r2=579262&view=diff
==============================================================================
--- webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/SenderWorker.java (original)
+++ webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/SenderWorker.java Tue Sep 25 07:35:44 2007
@@ -547,10 +547,6 @@
 				responseMessageContext.setProperty(HTTPConstants.MTOM_RECEIVED_CONTENT_TYPE, requestMsgOpCtx
 								.getProperty(HTTPConstants.MTOM_RECEIVED_CONTENT_TYPE));
 
- responseMessageContext.setOperationContext(requestMsgOpCtx);
-                if ( !requestMsgOpCtx.isComplete()) {
-                    requestMsgOpCtx.addMessageContext(responseMessageContext);
-                }
 				//If the response MsgCtx was not available Axis2 would hv put the transport info into a 
 				//HashMap, getting the data from it.
 				HashMap transportInfoMap = (HashMap) msgCtx.getProperty(Constants.Configuration.TRANSPORT_INFO_MAP);



---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org


Re: svn commit: r579262 - /webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/SenderWorker.java

Posted by Deepal jayasinghe <de...@gmail.com>.
> Author: gatfora
> Date: Tue Sep 25 07:35:44 2007
> New Revision: 579262
>
> URL: http://svn.apache.org/viewvc?rev=579262&view=rev
> Log:
> Undo changes made to SenderWorker as this breaks the Sandesha unit tests.  The particular case broken is when a sync ack is sent on an Async request/response, the OpContext was being completed so no async response would ever be sent
>   
hmm , according to the code and by debugging what I understood was it is
handling the response. So in the case of response processing one of the
thing Axis2 does is set the operation context and all the other contexts
if they are available. That is why I fixed that , in the meantime I got
an NPE in Axis2 due to this when using RM. The NPE is due to unexpected
dispatching , to fix that issue the only way is to fill the response
message context with the request message context data.


Thanks
Deepal
> Modified:
>     webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/SenderWorker.java
>
> Modified: webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/SenderWorker.java
> URL: http://svn.apache.org/viewvc/webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/SenderWorker.java?rev=579262&r1=579261&r2=579262&view=diff
> ==============================================================================
> --- webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/SenderWorker.java (original)
> +++ webservices/sandesha/trunk/java/modules/core/src/main/java/org/apache/sandesha2/workers/SenderWorker.java Tue Sep 25 07:35:44 2007
> @@ -547,10 +547,6 @@
>  				responseMessageContext.setProperty(HTTPConstants.MTOM_RECEIVED_CONTENT_TYPE, requestMsgOpCtx
>  								.getProperty(HTTPConstants.MTOM_RECEIVED_CONTENT_TYPE));
>  
> - responseMessageContext.setOperationContext(requestMsgOpCtx);
> -                if ( !requestMsgOpCtx.isComplete()) {
> -                    requestMsgOpCtx.addMessageContext(responseMessageContext);
> -                }
>  				//If the response MsgCtx was not available Axis2 would hv put the transport info into a 
>  				//HashMap, getting the data from it.
>  				HashMap transportInfoMap = (HashMap) msgCtx.getProperty(Constants.Configuration.TRANSPORT_INFO_MAP);
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: sandesha-dev-help@ws.apache.org
>
>
>   


-- 
Thanks,
Deepal
................................................................
"The highest tower is built one brick at a time"


---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org