You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/28 21:04:08 UTC

[GitHub] [arrow] ianmcook commented on a change in pull request #10583: ARROW-11675: [CI][C++] Resolve ctest failures on VS 2019 builds

ianmcook commented on a change in pull request #10583:
URL: https://github.com/apache/arrow/pull/10583#discussion_r660115576



##########
File path: dev/tasks/vcpkg-tests/github.windows.yml
##########
@@ -36,6 +36,7 @@ jobs:
           git -C arrow checkout FETCH_HEAD
           git -C arrow submodule update --init --recursive
       - name: Remove and Reinstall vcpkg
+        # TODO: this comment seems outdated, the vcpkg on GHA is quite recent.

Review comment:
       @pitrou versions of vcpkg rapidly stop working until updated, and the most reliable way to update vcpkg is simply to remove and reinstall it, as is done here. I'm not surprised that removing the reinstall step would trigger an error.
   
   The comment lines 39–45 could be removed. I think the final two lines of this comment (`# When running...`) are probably sufficient.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org