You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "rishabhdaim (via GitHub)" <gi...@apache.org> on 2023/05/22 15:15:55 UTC
[GitHub] [jackrabbit-oak] rishabhdaim commented on a diff in pull request #946: OAK-10250: Configurable suspend timeout
rishabhdaim commented on code in PR #946:
URL: https://github.com/apache/jackrabbit-oak/pull/946#discussion_r1200659742
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Configuration.java:
##########
@@ -281,4 +282,10 @@
name = "Document Node Store Compression",
description = "Select compressor type for collections. 'Snappy' is the default supported compression.")
String collectionCompressionType() default "snappy";
+
+ @AttributeDefinition(
+ name = "Suspend timeout",
+ description = "Timeout for a suspended commit after it conflicted with" +
+ "a change that is not yet visible. Default: 60000 (milliseconds).")
+ long suspendTimeoutMillis() default DEFAULT_SUSPEND_TIMEOUT;
Review Comment:
I would avoid `millis` in API name. This is standard across all the other APIs
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Configuration.java:
##########
@@ -281,4 +282,10 @@
name = "Document Node Store Compression",
description = "Select compressor type for collections. 'Snappy' is the default supported compression.")
String collectionCompressionType() default "snappy";
+
+ @AttributeDefinition(
+ name = "Suspend timeout",
+ description = "Timeout for a suspended commit after it conflicted with" +
+ "a change that is not yet visible. Default: 60000 (milliseconds).")
+ long suspendTimeoutMillis() default DEFAULT_SUSPEND_TIMEOUT;
Review Comment:
```suggestion
long commitSuspendTimeout() default DEFAULT_SUSPEND_TIMEOUT;
```
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Configuration.java:
##########
@@ -281,4 +282,10 @@
name = "Document Node Store Compression",
description = "Select compressor type for collections. 'Snappy' is the default supported compression.")
String collectionCompressionType() default "snappy";
+
+ @AttributeDefinition(
+ name = "Suspend timeout",
Review Comment:
```suggestion
name = "Commit Suspend timeout",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org