[GitHub] [skywalking] wankai123 commented on a diff in pull request #10616: Support isEmptyValue flag for metrics query.

["wankai123 (via GitHub)" <gi...@apache.org>]

wankai123 commented on code in PR #10616:
URL: https://github.com/apache/skywalking/pull/10616#discussion_r1152704952


##########
test/e2e-v2/cases/php/expected/metrics-has-value.yml:
##########
@@ -15,5 +15,11 @@
 
 {{- contains . }}
 - key: {{ notEmpty .key }}
-  value: {{ ge .value 2 }}
+  value:
+    value: 0
+    isemptyvalue: true

Review Comment:
   Because the default query time range is lookback 30m, should have empty values.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org