You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "CalvinKirs (via GitHub)" <gi...@apache.org> on 2024/03/14 11:27:23 UTC
[PR] [CALCITE-6331]Add missing license file [calcite]
CalvinKirs opened a new pull request, #3734:
URL: https://github.com/apache/calcite/pull/3734
[CALCITE-6331](https://issues.apache.org/jira/browse/CALCITE-6331)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6331]Add missing license file [calcite]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #3734:
URL: https://github.com/apache/calcite/pull/3734#issuecomment-1997580798
> @CalvinKirs Please check my comment under [CALCITE-6331](https://issues.apache.org/jira/browse/CALCITE-6331) and/or the content of previous releases (e.g., https://dlcdn.apache.org/calcite/apache-calcite-1.36.0/).↳
I misunderstood, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6331]Add missing license file [calcite]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #3734:
URL: https://github.com/apache/calcite/pull/3734#issuecomment-1997598195
> > I have the impressions that these licenses are automatically bundled inside the `licenses` folder when building and releasing the project so they are not really missing.↳↳
>
> @CalvinKirs Some files I know seem to generate licenses in the release version. I know some communities do this, such as flink-kubernetes-operator. I'm not sure if calcite is the case↳
Managing source dependencies with scripts is usually a challenging task. Even in Calcite, we maintain a duplicate of the source dependencies and reference the copy location in the LICENSE file. While I'm not familiar with Flink, I would wager that their automation isn't fully automated in the strictest sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6331]Add missing license file [calcite]
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #3734:
URL: https://github.com/apache/calcite/pull/3734#issuecomment-1997482827
@CalvinKirs Please check my comment under CALCITE-6331 and/or the content of previous releases (e.g., https://dlcdn.apache.org/calcite/apache-calcite-1.36.0/).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6331]Add missing license file [calcite]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on PR #3734:
URL: https://github.com/apache/calcite/pull/3734#issuecomment-1997511902
> > I have the impressions that these licenses are automatically bundled inside the `licenses` folder when building and releasing the project so they are not really missing.↳
@CalvinKirs Some files I know seem to generate licenses in the release version. I know some communities do this, such as flink-kubernetes-operator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6331]Add missing license file [calcite]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on PR #3734:
URL: https://github.com/apache/calcite/pull/3734#issuecomment-1997345051
> I have the impressions that these licenses are automatically bundled inside the `licenses` folder when building and releasing the project so they are not really missing.↳
https://www.apache.org/legal/release-policy.html#distributing-code-under-several-licenses at least we need a pointer.
what do you mean by automatic? I don't think this can be done automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6331]Add missing license file [calcite]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs commented on code in PR #3734:
URL: https://github.com/apache/calcite/pull/3734#discussion_r1524683839
##########
LICENSE:
##########
@@ -183,14 +183,103 @@ Additional License files can be found in the 'licenses' folder located in the sa
MIT
* font-awesome:font-awesome-code:4.2.0
site/_sass/_font-awesome.scss
Review Comment:
The 4.2 version of font-awesome-code doesn't include a LICENSE file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6331]Add missing license file [calcite]
Posted by "CalvinKirs (via GitHub)" <gi...@apache.org>.
CalvinKirs closed pull request #3734: [CALCITE-6331]Add missing license file
URL: https://github.com/apache/calcite/pull/3734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org