You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/06 14:10:59 UTC

[GitHub] [incubator-shardingsphere] kimmking opened a new pull request #4635: Migrating sharding-orchestration-reg-etcd from opensharding repo

kimmking opened a new pull request #4635: Migrating sharding-orchestration-reg-etcd from opensharding repo
URL: https://github.com/apache/incubator-shardingsphere/pull/4635
 
 
   Fixes #4628 .
   
   Changes proposed in this pull request:
   - Migrating sharding-orchestration-reg-etcd from opensharding repo
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4635: Migrating sharding-orchestration-reg-etcd from opensharding repo

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4635: Migrating sharding-orchestration-reg-etcd from opensharding repo
URL: https://github.com/apache/incubator-shardingsphere/pull/4635#issuecomment-595801143
 
 
   ## Pull Request Test Coverage Report for [Build 10084](https://coveralls.io/builds/29181088)
   
   * **22** of **44**   **(50.0%)**  changed or added relevant lines in **3** files are covered.
   * **18** unchanged lines in **3** files lost coverage.
   * Overall coverage decreased (**-0.1%**) to **59.007%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-etcd/src/main/java/org/apache/shardingsphere/orchestration/center/instance/EtcdInstance.java](https://coveralls.io/builds/29181088/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-etcd%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FEtcdInstance.java#L61) | 18 | 40 | 45.0%
   <!-- | **Total:** | **22** | **44** | **50.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29181088/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/history/HistoryDataSyncTask.java](https://coveralls.io/builds/29181088/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2Fhistory%2FHistoryDataSyncTask.java#L116) | 7 | 76.47% |
   | [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/channel/MemoryChannel.java](https://coveralls.io/builds/29181088/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2Fchannel%2FMemoryChannel.java#L61) | 8 | 51.85% |
   <!-- | **Total:** | **18** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29181088/badge)](https://coveralls.io/builds/29181088) |
   | :-- | --: |
   | Change from base [Build 1007](https://coveralls.io/builds/29176669): |  -0.1% |
   | Covered Lines: | 12139 |
   | Relevant Lines: | 20572 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4635: Migrating sharding-orchestration-reg-etcd from opensharding repo

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4635: Migrating sharding-orchestration-reg-etcd from opensharding repo
URL: https://github.com/apache/incubator-shardingsphere/pull/4635#issuecomment-595810716
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4635?src=pr&el=h1) Report
   > Merging [#4635](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4635?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/cb256f392838a6ad04e4ed1992a84c497d07b7e3?src=pr&el=desc) will **decrease** coverage by `0.05%`.
   > The diff coverage is `47.72%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4635/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4635?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4635      +/-   ##
   ============================================
   - Coverage     55.51%   55.45%   -0.06%     
   - Complexity      421      428       +7     
   ============================================
     Files          1131     1134       +3     
     Lines         20507    20572      +65     
     Branches       3799     3807       +8     
   ============================================
   + Hits          11384    11408      +24     
   - Misses         8405     8445      +40     
   - Partials        718      719       +1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4635?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../orchestration/center/instance/EtcdProperties.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4635/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1ldGNkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NlbnRlci9pbnN0YW5jZS9FdGNkUHJvcGVydGllcy5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | |
   | [...hestration/center/instance/EtcdPropertiesEnum.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4635/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1ldGNkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NlbnRlci9pbnN0YW5jZS9FdGNkUHJvcGVydGllc0VudW0uamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | |
   | [...re/orchestration/center/instance/EtcdInstance.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4635/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci1ldGNkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NlbnRlci9pbnN0YW5jZS9FdGNkSW5zdGFuY2UuamF2YQ==) | `42.5% <42.5%> (ø)` | `8 <8> (?)` | |
   | [...gment/select/projection/impl/ColumnProjection.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4635/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXJlbGF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3JlbGF0aW9uL3NlZ21lbnQvc2VsZWN0L3Byb2plY3Rpb24vaW1wbC9Db2x1bW5Qcm9qZWN0aW9uLmphdmE=) | `66.66% <0%> (-33.34%)` | `0% <0%> (ø)` | |
   | [...ent/select/projection/engine/ProjectionEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4635/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXJlbGF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3JlbGF0aW9uL3NlZ21lbnQvc2VsZWN0L3Byb2plY3Rpb24vZW5naW5lL1Byb2plY3Rpb25FbmdpbmUuamF2YQ==) | `83.87% <0%> (-16.13%)` | `0% <0%> (-1%)` | |
   | [.../sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4635/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvdmlzaXRvci9pbXBsL1Bvc3RncmVTUUxETUxWaXNpdG9yLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...phere/sql/parser/visitor/impl/MySQLDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4635/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvaW1wbC9NeVNRTERNTFZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...nt/select/projection/impl/ShorthandProjection.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4635/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXJlbGF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3JlbGF0aW9uL3NlZ21lbnQvc2VsZWN0L3Byb2plY3Rpb24vaW1wbC9TaG9ydGhhbmRQcm9qZWN0aW9uLmphdmE=) | `75% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...here/sql/parser/visitor/impl/OracleDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4635/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW9yYWNsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci92aXNpdG9yL2ltcGwvT3JhY2xlRE1MVmlzaXRvci5qYXZh) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...phere/sql/parser/visitor/impl/SQL92DMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4635/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXNxbDkyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvaW1wbC9TUUw5MkRNTFZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | ... and [6 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4635/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4635?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4635?src=pr&el=footer). Last update [cb256f3...2db636e](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4635?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4635: Migrating sharding-orchestration-reg-etcd from opensharding repo

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4635: Migrating sharding-orchestration-reg-etcd from opensharding repo
URL: https://github.com/apache/incubator-shardingsphere/pull/4635
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4635: Migrating sharding-orchestration-reg-etcd from opensharding repo

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4635: Migrating sharding-orchestration-reg-etcd from opensharding repo
URL: https://github.com/apache/incubator-shardingsphere/pull/4635#issuecomment-595801143
 
 
   ## Pull Request Test Coverage Report for [Build 2013](https://coveralls.io/builds/29181392)
   
   * **22** of **44**   **(50.0%)**  changed or added relevant lines in **3** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage decreased (**-0.02%**) to **59.085%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-etcd/src/main/java/org/apache/shardingsphere/orchestration/center/instance/EtcdInstance.java](https://coveralls.io/builds/29181392/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-etcd%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FEtcdInstance.java#L61) | 18 | 40 | 45.0%
   <!-- | **Total:** | **22** | **44** | **50.0%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29181392/badge)](https://coveralls.io/builds/29181392) |
   | :-- | --: |
   | Change from base [Build 1007](https://coveralls.io/builds/29176669): |  -0.02% |
   | Covered Lines: | 12155 |
   | Relevant Lines: | 20572 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4635: Migrating sharding-orchestration-reg-etcd from opensharding repo

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4635: Migrating sharding-orchestration-reg-etcd from opensharding repo
URL: https://github.com/apache/incubator-shardingsphere/pull/4635#issuecomment-595801143
 
 
   ## Pull Request Test Coverage Report for [Build 2012](https://coveralls.io/builds/29180224)
   
   * **22** of **44**   **(50.0%)**  changed or added relevant lines in **3** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage decreased (**-0.02%**) to **59.085%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-etcd/src/main/java/org/apache/shardingsphere/orchestration/center/instance/EtcdInstance.java](https://coveralls.io/builds/29180224/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-etcd%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FEtcdInstance.java#L61) | 18 | 40 | 45.0%
   <!-- | **Total:** | **22** | **44** | **50.0%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29180224/badge)](https://coveralls.io/builds/29180224) |
   | :-- | --: |
   | Change from base [Build 1007](https://coveralls.io/builds/29176669): |  -0.02% |
   | Covered Lines: | 12155 |
   | Relevant Lines: | 20572 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services