You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "anupamaggarwal (via GitHub)" <gi...@apache.org> on 2024/02/29 08:01:59 UTC

[PR] [hotfix][table] Fix typo in maven shade configuration [flink]

anupamaggarwal opened a new pull request, #24413:
URL: https://github.com/apache/flink/pull/24413

   ## What is the purpose of the change
   
   Fix typo in <includes> configuration of maven-shade plugin for  flink-table/flink-sql-jdbc-driver-bundle pom
   
   
   ## Brief change log
   - update `<include>` in place of  `<incldue>`
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hotfix][table] Fix typo in maven shade configuration [flink]

Posted by "rmetzger (via GitHub)" <gi...@apache.org>.
rmetzger commented on PR #24413:
URL: https://github.com/apache/flink/pull/24413#issuecomment-1972811146

   CI has passed. Merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hotfix][table] Fix typo in maven shade configuration [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24413:
URL: https://github.com/apache/flink/pull/24413#issuecomment-1970613782

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "05d135ae6ebd893beaa4a46ca4d24fb5352482b2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "05d135ae6ebd893beaa4a46ca4d24fb5352482b2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 05d135ae6ebd893beaa4a46ca4d24fb5352482b2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hotfix][table] Fix typo in maven shade configuration [flink]

Posted by "rmetzger (via GitHub)" <gi...@apache.org>.
rmetzger merged PR #24413:
URL: https://github.com/apache/flink/pull/24413


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hotfix][table] Fix typo in maven shade configuration [flink]

Posted by "rmetzger (via GitHub)" <gi...@apache.org>.
rmetzger commented on PR #24413:
URL: https://github.com/apache/flink/pull/24413#issuecomment-1970765666

   I will wait until CI has passed before we merge this. We are changing the contents of a jar, this might cause build failures.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org