[GitHub] [trafficserver] SolidWallOfCode commented on pull request #9018: dns error logging to diags

[GitBox <gi...@apache.org>]

SolidWallOfCode commented on PR #9018:
URL: https://github.com/apache/trafficserver/pull/9018#issuecomment-1235892217

   Seems fine. A couple of notes, although not worth delaying the merge.
   
   For the names, we might consider using [Lexicon](http://docs.solidwallofcode.com/libswoc/code/Lexicon.en.html), although the utility is less because it's a one way conversion. I might be tempted to have an array of string pairs, to group the tag and description, but then the use site is more complex. This is pretty deep in the style weeds so take them as potential ideas for future work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org